Skip to content

Commit

Permalink
Merge-12-12 (#2130)
Browse files Browse the repository at this point in the history
* Bump braces from 3.0.2 to 3.0.3 in /accessibility-checker-extension

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Starter project

* Basic config files

* Config starter

* Process config files

* Report signs of life

* First report

* Baselines

* Scan summaries

* Add jar build

* Java test suite

* Add java test to PRs

* Make headless

* Git chromedriver

* debug

* Add env

* Chrome driver dir

* headless new

* debug

* debug

* Debug

* Set bin path

* Fix test

* Output progress

* change path

* Metrics and copyright

* Don't record our own tests

* Javadoc updates

* Basic javadoc cleanup

* Test build

* yaml syntax

* working directory

* Generate pom

* package write

* switch token

* Generate pom

* Wrong gradle?

* creds

* Add boilerplate

* Move files into equalaccess sub namespace

* Change boilerplate dependency version

* Flip expected, actual

* More isolation of selenium dependency

* CSV report / memory improvements

* A minimal issue params to the help urls

* Tighten dependencies, IOException

* Tweak dependencies to not include selenium

* Do all of the 'pass' processing in the page context

* add test cases and update rule logic

* Do counting and "pass" filtering in the checking context

* typescript

* Wrong variable

* Fix counting

* Typescript bug

* init counts

* fix count

* Handle large result

* Debug

* update the rule and the test case result #1958

* adding id to link in reportTreeGrid

* stop propagation of containing div in reportTreeGrid

* Fix cypress baseline

* Bump axios from 1.7.3 to 1.7.4 in /rule-server (#1991)

Bumps [axios](https://github.com/axios/axios) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.7.3...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump axios from 1.6.8 to 1.7.4 in /accessibility-checker-extension/test (#1990)

Bumps [axios](https://github.com/axios/axios) from 1.6.8 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.8...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ErickR <[email protected]>

* Bump micromatch from 4.0.7 to 4.0.8 in /report-react

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.7 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.7...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* update the rules #1958

* update the img_alt_null rule #1958

* update the baselines #1958

* update the baselines #1958

* update the help reference #1958

* Bump axios from 1.6.2 to 1.7.5 in /cypress-accessibility-checker

Bumps [axios](https://github.com/axios/axios) from 1.6.2 to 1.7.5.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.2...v1.7.5)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump webpack from 5.79.0 to 5.94.0 in /accessibility-checker-extension

Bumps [webpack](https://github.com/webpack/webpack) from 5.79.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.79.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* Rule server for 8-30

* added icons,changed css and bg color

* Switch from gradle to maven

* fix maven test

* chromedriver missing in deploy

* corrected import and images

* Start local rule server for testing

* changes

* Deploy test

* correction in filter sort

* seprating images

* changes in utilimages

* correction in expression of elements

* commenting hidden filter

* Try deploy from git

* ioctl error

* Try another way to pass key

* gpg import

* import key

* gpg

* param order

* gpg loopback

* Update common/module/src/report/ACReporterHTML.tsx

* Try jar package

* Rename ACReporterHTML.tsx to ACReporterHTML.ts

* maven compiler props

* Setup release deployments for java checker

* Add note to README

* Add Playwright support

* Add Playwright support

* Starting javadoc

* Javadoc updates

* Enable playwrite screenshots, and report.toString

* Add copyright statement to javadoc

* Fix for Firefox

* Fixes for Firefox

* changes for hidden filter

* changes for hidden icon

* correction in total issue

* change in link text and css

* css changes

* css changes

* css change

* css changes

* set initial expand true and change filter order

* css changes

* Fix artifact failures (#2038)

* Bump path-to-regexp and express in /report-react

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump send and express in /rule-server

Bumps [send](https://github.com/pillarjs/send) to 0.19.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.18.0...0.19.0)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump serve-static and express in /report-react (#2043)

Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: serve-static
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump body-parser and express in /rule-server (#2039)

* Bump body-parser and express in /rule-server

Bumps [body-parser](https://github.com/expressjs/body-parser) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.20.2...1.20.3)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: body-parser
  dependency-type: direct:production
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump path-to-regexp and express in /report-react

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ErickR <[email protected]>

* Bump path-to-regexp and express in /rule-server (#2032)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.10 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Bump webpack from 5.76.3 to 5.94.0 in /report-react (#2044)

* Bump path-to-regexp and express in /report-react

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump webpack from 5.76.3 to 5.94.0 in /report-react

Bumps [webpack](https://github.com/webpack/webpack) from 5.76.3 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.76.3...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ErickR <[email protected]>

* Bump braces from 3.0.2 to 3.0.3 in /common/module (#2031)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ErickR <[email protected]>

* css changes

* css changes

* score css change

* font weight of score

* change in icon order and summary card border

* color change for summary card

* bg color of extenstion summ & border in html report

* Update guides and screenshots for new interactive HTML reports

* add single quote

* Add three 7.3 rules into the main policy

* Update object verification

* Fix label

* Update More info

* Default Oct 1, 2024

* Default Oct 1, 2024

* Change label

* update

* Update server

* Update archives.json

* chore(engine): Generate a spreadsheet of rule mappings as an artifact for PRs (#2071)

* Rule spreadsheet

* Comment instead of delete messages that weren't generic

* Bump cookie and express in /report-react (#2073)

Bumps [cookie](https://github.com/jshttp/cookie) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](jshttp/cookie@v0.6.0...v0.7.1)

Updates `express` from 4.21.0 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.21.0...4.21.1)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Bump markdown-to-jsx in /accessibility-checker-extension (#2072)

Bumps [markdown-to-jsx](https://github.com/quantizor/markdown-to-jsx) from 7.1.9 to 7.5.0.
- [Release notes](https://github.com/quantizor/markdown-to-jsx/releases)
- [Changelog](https://github.com/quantizor/markdown-to-jsx/blob/main/CHANGELOG.md)
- [Commits](quantizor/markdown-to-jsx@v7.1.9...v7.5.0)

---
updated-dependencies:
- dependency-name: markdown-to-jsx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Bump axios from 1.6.1 to 1.7.7 in /accessibility-checker-extension (#2064)

Bumps [axios](https://github.com/axios/axios) from 1.6.1 to 1.7.7.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.1...v1.7.7)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Bump rollup from 2.75.6 to 2.79.2 in /report-react (#2059)

Bumps [rollup](https://github.com/rollup/rollup) from 2.75.6 to 2.79.2.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.75.6...v2.79.2)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Bump axios from 1.6.0 to 1.7.4 in /common/module (#2046)

Bumps [axios](https://github.com/axios/axios) from 1.6.0 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.0...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Cleanup sed version setting (#2075)

* Bump http-proxy-middleware from 2.0.6 to 2.0.7 in /report-react (#2076)

Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(java): Fix exception when baseline has fewer issues than what is returned by scan (#2078)

* Wrong variable used in diff

* Add test with an item removed from the baseline

* fix(engine): rule engine refactor and update (#2025)

* Code clean up: separate CSSUtil #1974

* code cleanup: use ts classes instead of functions #1974

* refactor the rule code #1974

* code refactor #1974

* code refactor for legacy #1974

* create NodeWalker #1974

* refactor rules #1974

* update the rules #1974

* update the rule engine #1974

* add denug for testing #1974

* add debug for testing #1974

* clear up debug statement #1974

* update rules for resolved role #1974

* update aria definition #1974

* update ethe resolvedRole in rules #1974

* refactor the rule aria_accessiblename_exists #1974

* add console logs for debugging  #1974

* update the rules #1974

* refactor isNodeVisible function #1974

* refactor isNodeVisible #1974

* update the role calculation #1974

* update the common util #1974

* update the aria path which contains presentation  #1974

* update accessible name calculation #1974

* update the CommonUtil #1974

* update svg and ariaautocomplete calculation #1974

* update svg rule to use accNameUtil #1974

* Update AccNameUtil #1974

* update the rules for accessible name calculation #1974

* update accName #1974

* update rules to use new Acc name calculation #1974

* update the rule for acc name #1974

* update the rules to use new acc name calculation #1974

* update the rules and test cases #1974

* update the rules to use accessible name calculation #1974

* update the rules to use new accessible name #1974

* fix merge error #1974

* fix the baselines #1974

* update the selenium baselines #1974

* Update JSONObjectStructureVerification.html.json

* Update JSONObjectStructureVerificationSelenium.html.json

* Update violations.json

* Update DOMWalker.ts

* fix the error "TypeError: Cannot read properties of null (reading 'nodeType')" from the cache #1974

* Update label_name_visible.ts

* update target spacing rule #1974

* update spaing rule #1974

* update DOMWalker #1974

* recalculate the inline text status #1974

* update spacing rule and test results #1974

* clean up the code #1974

* fix the baseline #1974

* update the baseline #1974

* update the baselines #1974

* update puppeteer test skip file list #1974

* update ignored test files #1974

* skip 3 test files #1974

* skip three test files in java test #1974

* java test file update #1974

* Update AccessibilityCheckerSeleniumFFTest.java

* clean up the code #1974

* remove util package from dependency #1974

* Fix wording typo #1974

* Protect from walking at the document level

* Missing space

* update the test case #1974

* Path fix?

* Handle slot assignments better

* Fix sibling accidentally entering slot

* Update the ARIA Walker

* Kill hang

---------

Co-authored-by: Tom Brunet <[email protected]>

* Create archive for Nov 6 (#2086)

* prevent unnecessary update (#2093)

* fixrule(`aria_landmark_name_unique`): Change the accessible name length limitation (#2096)

* Testcase for aria_landmark_name_unique failure

* Check th existence of design pattern from the aria definition

* update the accessible name length

---------

Co-authored-by: Tom Brunet <[email protected]>

* Bug found by DCS related to list, but cause by prevNode (#2094)

Co-authored-by: Shunguo Yan <[email protected]>

* Java baseline bug (#2097)

Co-authored-by: Shunguo Yan <[email protected]>

* Create Nov 13 archive (#2098)

* Update issue templates

* Update pull_request_template.md

* Bump cross-spawn from 7.0.3 to 7.0.6 in /report-react (#2105)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update pull_request_template.md

Use h3 header

* update Issue templates yaml files (#2114)

* Update bug_report.yaml

* Update bug_report.yaml

* Update bug_report.yaml

* Update bug_report.yaml

* Update bug_report.yaml

* Update accessibility_issue.yaml

* Update accessibility_issue.yaml

* Update bug_report.yaml

* Use cache for visibility (#2112)

* Bump path-to-regexp and express in /report-react (#2119)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.1 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.1...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fixrule(`img_alt_null`, `aria_accessiblename_exists`) Update the rule mappings to be consistent with ACT rules (#2108)

* update the rule and test cases #2090

* add the help reference #2090

* Update aria_accessiblename_exists.ts

* fix baselines #2090

* update the test case #2090

* code clean up #2090

* undo change #2090

* Update Baseline_aChecker.Baseline.html.json

* Update JSONObjectStructureVerification.html.json

* Update JSONObjectStructureVerificationSelenium.html.json

* Update achecker.cy.js

* Update achecker.cy.js

* Create violations-no-match-diff.json

* clean up code #2090

* Update violations.json

* Update achecker.cy.js

* update ACT mapping #2090

* update reasonCode mapping #1090

---------

Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Phill Jenkins <[email protected]>

* Bump nanoid from 3.3.4 to 3.3.8 in /report-react (#2126)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.4 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.4...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* Dec 12 archive (#2129)

* Update object verification

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ErickR <[email protected]>
Co-authored-by: Shunguo <[email protected]>
Co-authored-by: nam-singh <[email protected]>
Co-authored-by: drjoho <[email protected]>
Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Erick Renteria <[email protected]>
Co-authored-by: Will Scott <[email protected]>
  • Loading branch information
9 people authored Dec 13, 2024
1 parent 01c107f commit 89a2072
Show file tree
Hide file tree
Showing 202 changed files with 101,751 additions and 168 deletions.
28 changes: 17 additions & 11 deletions accessibility-checker-engine/src/v4/checker/Checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,21 +311,27 @@ export class Checker implements IChecker {
}
for (const rsId of rsIds) {
if (rsId in rsInfo) {
Object.keys(rsInfo[rsId]).forEach(code => {
const reCode = new RegExp(`(^|--)${reasonCode}($|--)`);
Object.keys(rsInfo[rsId]).forEach(code => {
let level = null;
const reCode = new RegExp(`(^|--)${reasonCode}($|--)`);
if (code === 'None')
level = rsInfo[rsId]["None"];
else if (reCode.test(code))
level = rsInfo[rsId][code];
if (level === eRulePolicy.VIOLATION) {
retVal = eRulePolicy.VIOLATION;
} else if (level === eRulePolicy.RECOMMENDATION && retVal === null) {
retVal = eRulePolicy.RECOMMENDATION;
} else if (retVal === null) {
retVal = eRulePolicy.INFORMATION;
}
});
level = rsInfo[rsId][code];

if (level !== null) {
if (level === eRulePolicy.VIOLATION) {
retVal = eRulePolicy.VIOLATION;
} else if (level === eRulePolicy.RECOMMENDATION && retVal === null) {
retVal = eRulePolicy.RECOMMENDATION;
} else if (retVal === null) {
retVal = eRulePolicy.INFORMATION;
}
}
});
if (retVal === null) {
retVal = eRulePolicy.INFORMATION;
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
import { Rule, RuleResult, RuleFail, RuleContext, RulePass, RuleContextHierarchy } from "../api/IRule";
import { eRulePolicy, eToolkitLevel } from "../api/IRule";
import { AriaUtil } from "../util/AriaUtil";
import { CommonUtil } from "../util/CommonUtil";
import { VisUtil } from "../util/VisUtil";
import { ARIADefinitions } from "../../v2/aria/ARIADefinitions";
import { AccNameUtil } from "../util/AccNameUtil";

export const aria_accessiblename_exists: Rule = {
Expand All @@ -26,32 +24,42 @@ export const aria_accessiblename_exists: Rule = {
"en-US": {
"pass": "aria_accessiblename_exists.html",
"fail_no_accessible_name": "aria_accessiblename_exists.html",
"fail_no_accessible_name_image": "aria_accessiblename_exists.html",
"group": "aria_accessiblename_exists.html"
}
},
messages: {
"en-US": {
"pass": "An accessible name is provided for the element",
"fail_no_accessible_name": "Element <{0}> with \"{1}\" role has no accessible name",
"fail_no_accessible_name_image": "Element <{0}> with \"{1}\" role has no accessible name",
"group": "Elements with certain roles should have accessible names"
}
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["4.1.2"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
"toolkitLevel": eToolkitLevel.LEVEL_ONE,
reasonCodes: ["fail_no_accessible_name"]
},
{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["ARIA"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE,
reasonCodes: ["fail_no_accessible_name_image"]
}],
act: [],
act: [{"23a2a8": {"fail_no_accessible_name_image": "fail"}}],
run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
const ruleContext = context["dom"].node as Element;

//skip the rule
if (VisUtil.isNodeHiddenFromAT(ruleContext)) return null;

let nodeName = ruleContext.nodeName.toLocaleLowerCase();
// svg element is handled in svg_graphics)labbelled rule
if (nodeName === 'svg') return;
// svg element is handled in svg_graphics_labbelled rule and image rules
if (nodeName === 'svg' || nodeName === 'img') return;

// when table element with a caption as first child
if (nodeName === 'table'
Expand All @@ -69,9 +77,11 @@ export const aria_accessiblename_exists: Rule = {
let role = AriaUtil.getResolvedRole(ruleContext);

const name_pair = AccNameUtil.computeAccessibleName(ruleContext);
if (!name_pair || !name_pair.name || name_pair.name.trim().length === 0)
if (!name_pair || !name_pair.name || name_pair.name.trim().length === 0) {
if (role === 'img' || role === 'image')
return RuleFail("fail_no_accessible_name_image", [ruleContext.nodeName.toLowerCase(), role]);
return RuleFail("fail_no_accessible_name", [ruleContext.nodeName.toLowerCase(), role]);

}
return RulePass("pass");
}
}
13 changes: 11 additions & 2 deletions accessibility-checker-engine/src/v4/rules/img_alt_null.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,17 @@ export const img_alt_null: Rule = {
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.1.1"],
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
"toolkitLevel": eToolkitLevel.LEVEL_ONE,
reasonCodes: ["fail_decorative"]
},
{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["ARIA"],
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE,
reasonCodes: ["potential_aria_override"]
}
],
act: [{"46ca7f": {"potential_aria_override": "fail"}}],
run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
const ruleContext = context["dom"].node as Element;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,7 @@
UnitTest = {
ruleIds: ["aria_accessiblename_exists"],
results: [
{
"ruleId": "aria_accessiblename_exists",
"value": [
"INFORMATION",
"PASS"
],
"path": {
"dom": "/html[1]/body[1]/img[1]",
"aria": "/document[1]/img[1]"
},
"reasonId": "pass",
"message": "An accessible name is provided for the element",
"messageArgs": [],
"apiArgs": [],
"category": "Accessibility"
}

]
}
</script>
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker/src-ts/lib/ACHelper.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { existsSync, mkdirSync, writeFileSync, readFileSync } from "fs";
import { existsSync, mkdirSync, readFileSync, writeFileSync } from "fs";
import { dirname, join, resolve as pathResolve } from "path";
import { ICheckerReport, ICheckerResult } from "./api/IChecker.js";
import { ACBrowserManager } from "./ACBrowserManager.js";
Expand Down
Loading

0 comments on commit 89a2072

Please sign in to comment.