Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FD objective with fixed parameters fix #1446

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

PaulJonasJost
Copy link
Collaborator

@PaulJonasJost PaulJonasJost commented Aug 9, 2024

Fixed an issue when the objective used for the FD had a PrePostProcessor, i.e. fixed values. Also added it to the fd test

@PaulJonasJost PaulJonasJost self-assigned this Aug 9, 2024
@PaulJonasJost
Copy link
Collaborator Author

Closes #1445

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (6c6cdfe) to head (15c268e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1446      +/-   ##
===========================================
+ Coverage    83.38%   83.41%   +0.03%     
===========================================
  Files          161      161              
  Lines        13460    13461       +1     
===========================================
+ Hits         11224    11229       +5     
+ Misses        2236     2232       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Good consistency change, thanks!

@PaulJonasJost PaulJonasJost merged commit 08a1174 into develop Sep 5, 2024
18 checks passed
@PaulJonasJost PaulJonasJost deleted the FD_objective_bug branch September 5, 2024 07:37
This was referenced Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants