Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: improve profiling code #1447

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Profile: improve profiling code #1447

wants to merge 37 commits into from

Commits on Aug 8, 2024

  1. Initial working update

    Implement two targets: higher and lower. Choose which one to go to depending on first guess.
    Different calculation of next_obj_target
    
    TODO: change 1.5 to magic factor
    Doresic committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f05dce9 View commit details
    Browse the repository at this point in the history
  2. Add TODOs

    Doresic committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a465b62 View commit details
    Browse the repository at this point in the history
  3. Introduce adaptive max and min steps

    Implemented adaptive max and min steps in profiling. If the optimization during profiling fails (results in inf value), the algorithm will first try to iteratively decrease `max_step_size` to be closer to the last point that had a successful optimization. If that doesn't work (if we reduce max_step_size below min_step_size), then max_step_size is set back to the default and we try to increase min_step_size to "jump over" the problematic area.
    
    Resampling random points and start from those is only the last resort and will be done if these two do not work. The idea is that we want to stay as close as we can to the last profiling point.
    
    TODO: Put the adaptive reduction/increase of max_step_size/min_step_size into options
    Doresic committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2b02b9a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    275c890 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Bugfixes, Robustness, Logging, Better plotting

    - BUGFIX: absolute value in objective targets at last_delta_fval
    - BUGFIX: extrapolation explosions if we start at boundary
    - Feature: Trust region on extrapolation
    - Added y ticks back into the plot, sometimes the range is completely different.
    - Added points to the plotting of profiles (in case of one result and one profile list id)
    - Added color change to plotting of profiles (in case of one result and one profile list id)
    - LOGGING: added logging.INFO with informations of steps made and successful optimizations.
    Doresic committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e2480bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ce9890 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ee0aea9 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    75f3964 View commit details
    Browse the repository at this point in the history
  2. Add tuple to isinstance list

    Doresic committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5c911de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3cf940b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a500750 View commit details
    Browse the repository at this point in the history
  5. We're making more steps then before

    Test were testing whether the profiling method was making a lot of steps. Now we're making a lot more steps due to higher robustness.
    Doresic committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6914d19 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    9093474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c77a1b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f61e61e View commit details
    Browse the repository at this point in the history
  4. Update quality colors

    Doresic committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c8000d2 View commit details
    Browse the repository at this point in the history
  5. Fix failing test

    Doresic committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    08b7e2e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix test and docstring

    Doresic committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5e06be9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6525578 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eeb304d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'change_profiling' of https://github.com/ICB-DCM/pyPESTO

    …into change_profiling
    Doresic committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c65b199 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    beee8d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Change color if no

    Doresic committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1d80988 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    440319b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    814f552 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    7627288 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    5e86392 View commit details
    Browse the repository at this point in the history
  2. Paul review changes

    Doresic committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3c8ccd5 View commit details
    Browse the repository at this point in the history
  3. More Paul review changes

    Doresic committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c7697e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    7d8b50c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d74b84 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    93250b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Correct comment variable name

    Co-authored-by: Maren Philipps <[email protected]>
    Doresic and m-philipps authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    41411f3 View commit details
    Browse the repository at this point in the history
  2. Change i_color to color_i

    Doresic committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    649c53c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abae4e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Expand colors docstring

    Doresic committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8ef3b51 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    39a2948 View commit details
    Browse the repository at this point in the history