Clean up sampling tests #1486
Merged
Clean up sampling tests #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st) and marked as flakey.
…t as for of an exhibition, which is covered in the jupyter notebook "sampler_study"
PaulJonasJost
requested review from
dilpath,
Doresic and
m-philipps
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1486 +/- ##
===========================================
- Coverage 82.88% 82.87% -0.02%
===========================================
Files 163 163
Lines 13786 13786
===========================================
- Hits 11427 11425 -2
- Misses 2359 2361 +2 ☔ View full report in Codecov by Sentry. |
Doresic
approved these changes
Oct 10, 2024
dilpath
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks for the many improvements, including speeding things up! I don't think this addresses some of the unnecessary computation and non-deterministic behavior described in #1475 , but that can be revisited if failing tests become an issue again. Fine to merge and close/leave open that issue as you like.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should speed up most of the very slow tests in
base, clean up the code and thereby adress #1475