Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added top level menu option for config, and added bulk import to all 4 classes #44

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

erichester76
Copy link

I also changed the menu top level name to Software because it looks better in the top level.

If you want to move the meny top level just set this in plugins.py

PLUGINS_CONFIG = {
'netbox_slm': {
'top_level_menu': True,
},
}

@erichester76
Copy link
Author

I would suggest a squash, I worked in the repo. Sorry.

@wkoot
Copy link
Collaborator

wkoot commented Oct 14, 2024

I would suggest a squash, I worked in the repo. Sorry.

No problem, we're very happy to receive contributions. I'll clean up and do some testing before merge

wkoot pushed a commit that referenced this pull request Oct 14, 2024
Closes #42
Based on @erichester76's #44

Signed-off-by: wkoot <[email protected]>
wkoot added a commit that referenced this pull request Oct 14, 2024
Closes #42
Based on @erichester76's #44

Signed-off-by: wkoot <[email protected]>
Co-authored-by: Eric Hester <[email protected]>
wkoot pushed a commit that referenced this pull request Oct 14, 2024
@wkoot
Copy link
Collaborator

wkoot commented Oct 14, 2024

Hmm, there seem to be quite some errors when trying to use the import feature.
The output data produced by the Export (CSV) option is not importable itself, so testing is a bit complicated.
All fields which are externally referenced (i.e. foreign keys), need to be manually changed in the csv (or omitted).
Additionally, some of the field validation checks don't work as in the regular form: e.g. stored_location_url validation (being LaxURLField).
For now, I'll try to merge a limited set of fields for importing. Then we can work on adding the other fields later

wkoot pushed a commit that referenced this pull request Oct 14, 2024
@wkoot wkoot marked this pull request as draft October 14, 2024 11:40
wkoot added a commit that referenced this pull request Oct 14, 2024
Partially implements #4
Based on @erichester76's #44

Signed-off-by: wkoot <[email protected]>
Co-authored-by: Eric Hester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants