SOC Flowsheet #100
Merged
SOC Flowsheet #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To run CI against a version if to where 1234 is the PR number. |
bpaul4
approved these changes
Apr 23, 2024
| self.feed_heater.default_initializer( | ||
| solver=solver, solver_options=optarg, output_level=outlvl | ||
| ).initialize(model=self.feed_heater) | ||
| # self.sweep_heater.initialize(outlvl=outlvl, solver=solver, optarg=optarg) |
There was a problem hiding this comment.
Should these be uncommented, or removed?
| self.sweep_exchanger.default_initializer( | ||
| solver=solver, solver_options=optarg, output_level=outlvl | ||
| ).initialize(model=self.sweep_exchanger) | ||
| # self.sweep_exchanger.initialize(outlvl=outlvl, solver=solver, optarg=optarg) |
There was a problem hiding this comment.
Same question for the three commented lines here
There was a problem hiding this comment.
Forgot to remove the old versions when updating them to the new initialization format. Will take care of that.
AlexNoring
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
The examples are running for me as well. I have a few minor comments on the jupyter notebook, but can't comment at the specific locations since the file is too big.
- There is an unused import,
# from save_results import save_results - You should suppress missing scaling factor warnings to keep the output clean. The following code should work.
scaling_log = idaeslog.getLogger("idaes.core.util.scaling")
scaling_log.setLevel(idaeslog.ERROR)
- Near the end of section 2 there is a sentence that is missing a phrase. "Interior point solvers like IPOPT when unconstrained solutions occur too close to variable bounds."
- In section 3 the following text has "an" instead of "and". "Most MVs we want to ramp between the old an new setpoints"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the SOC flowsheet used in recent NMPC and model degradation papers as an example. A Jupyter notebook takes the user through classical control simulations.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--100.org.readthedocs.build/en/100/