Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with "idaesx new" command for new directories #101

Merged
merged 4 commits into from
May 9, 2024

Conversation

dangunter
Copy link
Member

@dangunter dangunter commented Apr 3, 2024

Fix idaesx new bug

Fixes #96

  • Improve logic to handle new directories (index file, no sections yet)
  • Also fix bug that was ignoring the "--git" option

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dangunter dangunter self-assigned this Apr 3, 2024
@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Apr 4, 2024
@lbianchi-lbl
Copy link
Contributor

@dallan-keylogic
Copy link
Contributor

Good news: it successfully added a missing sections tag. Bad (or weird) news: it did so after a comment:
image

Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit 8818ba7 into IDAES:main May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idaesx new command fails to register new examples
4 participants