Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed jenkinsfile and entire docker folder #1535

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

azaidi06
Copy link
Contributor

Fixes

This resolves issue #1511
#1511

Summary/Motivation:

The jenkinsfile is not being used and Docker is no longer being used, so all associated items are being removed from the repo

Changes proposed in this PR:

Deleted the single jenkinsfile and all the items within the docker folder

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (c4336ba) to head (e47cfcf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62335    62335              
  Branches    10222    10222              
==========================================
- Hits        48031    48028       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh what dreams we had for being able to use Docker and Jenkins...

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 15, 2024
@lbianchi-lbl lbianchi-lbl linked an issue Nov 19, 2024 that may be closed by this pull request
@lbianchi-lbl lbianchi-lbl merged commit 3fa6904 into IDAES:main Nov 19, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dockerfile + Jenkinsfile from repo
5 participants