Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/deployment scripts #2086

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Sep 23, 2023

PR Checklist

  • PR title descriptive (can be used in release notes)

TODO

  • Separate PR to get deployment from workflow runner (not deployment model)
  • ...

Description

Start process of refactoring deployment management. Main goals

  • Add tests for all deployment functionality
  • Simplify process of loading/caching deployments
  • Allow deployments to be loaded from JS environment
  • Remove synchronous deployment get methods (cannot run child subprocess)
  • Consider moving all deployment code to own workspace
  • Ensure all tests passing from yarn workspace scripts test:watch

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant