Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some corrections to Examples code...and updated README #98

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Some corrections to Examples code...and updated README #98

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2015

I made corrections to the MNIST and Hutter Prize examples, and updated the README with instructions for installing on Windows machines.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 128e428 on FissionChips621:master into 4f69701 on IDSIA:master.

@flukeskywalker
Copy link
Collaborator

Thanks for the PR!
However, your changes to the examples are incorrect. We updated the name of the outputs for layers like SigmoidCE to be predictions instead of probabilities for consistency (see layer implementations). If we indicate otherwise anywhere, it should be changed.

Also, the criterion argument is important to pay attention to: it indicates if the quantity of interest is expected to be maximized or minimized. It should not be changed to name. The name for the hook can be additionally specified, if the default name is not desirable.

@ghost
Copy link
Author

ghost commented Nov 21, 2015

Aye, my bad. I was still using the original brainstorm code I had downloaded a few weeks ago before you had made those changes to the examples. Will be more careful next time! Thanks for the clarifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants