Skip to content

Commit

Permalink
Merge pull request #151 from modos189/fix/firefox-id
Browse files Browse the repository at this point in the history
Fix firefox addon id
  • Loading branch information
modos189 committed Sep 2, 2024
2 parents 7c2a282 + 8573ba1 commit 958454a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@ jobs:
artifacts: ${{ env.FILE_PATH }}
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/upload-artifact@v4
- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: ${{ env.FILE_NAME }}
include-hidden-files: true
path: |
./build/
Expand Down Expand Up @@ -123,7 +125,9 @@ jobs:
- name: Get metadata
run: echo "GITHUB_SHA_SHORT=$(cat ./final_artifacts/.metadata/commit | cut -c 1-6)" >> $GITHUB_ENV

- uses: actions/upload-artifact@v4
- name: Upload general artifact
uses: actions/upload-artifact@v4
with:
name: iitc-button-${{ env.GITHUB_SHA_SHORT }}-artifacts
include-hidden-files: true
path: final_artifacts/*
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "iitc-button",
"version": "3.0.4",
"version": "3.0.5",
"repository": "https://github.com/IITC-CE/IITC-Button.git",
"license": "GPLv3",
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion vue.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const manifest_transformer = (manifest) => {

if (is_beta) {
manifest.name = `${manifest.name} Beta`;
manifest.browser_specific_settings.gecko.id = "[email protected]";
manifest.browser_action.default_icon["48"] =
"assets/icons/48/icon-beta.png";
manifest.browser_action.default_icon["96"] =
Expand Down Expand Up @@ -85,7 +86,6 @@ const manifest_v3_transformer = (manifest, browser) => {
];
}
if (browser === "firefox" || browser === "safari") {
manifest.browser_specific_settings.gecko.id = "[email protected]";
manifest.browser_specific_settings.gecko.strict_min_version = "109.0";
manifest.permissions.push("webRequestBlocking");
manifest.permissions.push("scripting");
Expand Down

0 comments on commit 958454a

Please sign in to comment.