-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intel link to match stock. #723
Conversation
It looks like when `/intel` was removed with e5fe5d8, stock was not adding the string to the URL. Currently it does in both the web and scanner apps. Closes IITC-CE#684.
🤖 Pull request artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something niantic didn't do properly...
We know they won't fix it but do we really want the same "bug" in iitc?
No need to argue, just asking 😉🤷♂️
While annoying, repeating strings in the hostname and path is not uncommon, and I wouldn't consider it a bug. Tabs I have open now that do this: The fact both of those are Google is not surprising. They've always been inconsistent about which way they want to go (which probably bled over into Niantic, particularly since maps.google.com/maps was a thing). |
Niantic changed from something.ingress.com/intel to intel.ingress.com without context path. This is clearly remained after this change and is clearly a bug or smth they didn't finish. Period. |
They are just as likely to someday require Meanwhile, their official software (both web and scanner) includes it. And IITC includes it when it generates a deep (scanner) link. So, this change removes an unnecessary difference between stock and IITC. |
Just checking to see if this has any hope of moving forward, or if I should just withdraw it. |
We can keep discussing this for years... and fiddling with it back and forth..or just wait for niantic to do something that would need an update here and change it then 😉 |
It looks like when
/intel
was removed with e5fe5d8, stock was not adding the string to the URL. Currently it does in both the web and scanner apps.Closes #684.