Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intel link to match stock. #723

Closed
wants to merge 1 commit into from

Conversation

nexushoratio
Copy link
Contributor

It looks like when /intel was removed with e5fe5d8, stock was not adding the string to the URL. Currently it does in both the web and scanner apps.

Closes #684.

It looks like when `/intel` was removed with e5fe5d8, stock was not adding
the string to the URL.  Currently it does in both the web and scanner apps.

Closes IITC-CE#684.
Copy link

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk cfeb8c1
test-0.38.1.20240330.212200.zip cfeb8c1

See build on website

Copy link
Contributor

@xscreach xscreach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something niantic didn't do properly...
We know they won't fix it but do we really want the same "bug" in iitc?
No need to argue, just asking 😉🤷‍♂️

@nexushoratio
Copy link
Contributor Author

This is something niantic didn't do properly... We know they won't fix it but do we really want the same "bug" in iitc? No need to argue, just asking 😉🤷‍♂️

While annoying, repeating strings in the hostname and path is not uncommon, and I wouldn't consider it a bug.

Tabs I have open now that do this:
mail.google.com/mail
calendar.google.com/calendar

The fact both of those are Google is not surprising. They've always been inconsistent about which way they want to go (which probably bled over into Niantic, particularly since maps.google.com/maps was a thing).

@xscreach
Copy link
Contributor

This is something niantic didn't do properly... We know they won't fix it but do we really want the same "bug" in iitc? No need to argue, just asking 😉🤷‍♂️

While annoying, repeating strings in the hostname and path is not uncommon, and I wouldn't consider it a bug.

Tabs I have open now that do this:
mail.google.com/mail
calendar.google.com/calendar

The fact both of those are Google is not surprising. They've always been inconsistent about which way they want to go (which probably bled over into Niantic, particularly since maps.google.com/maps was a thing).

Niantic changed from something.ingress.com/intel to intel.ingress.com without context path. This is clearly remained after this change and is clearly a bug or smth they didn't finish. Period.
Last month some old urls stoped working even though niantic supported them for so long.
I just don't want be changing this again when nia finds some people to work on ingress (haha)

@modos189
Copy link
Contributor

modos189 commented Apr 1, 2024

I agree with @xscreach that most likely /intel is an outdated url and at some point Niantic will finally update the url by making the default url without /intel
For the same reason this change was made to commit e5fe5d8

@nexushoratio
Copy link
Contributor Author

They are just as likely to someday require /intel as they are to do away with it.

Meanwhile, their official software (both web and scanner) includes it.

And IITC includes it when it generates a deep (scanner) link.

So, this change removes an unnecessary difference between stock and IITC.

@nexushoratio
Copy link
Contributor Author

Just checking to see if this has any hope of moving forward, or if I should just withdraw it.

@xscreach
Copy link
Contributor

xscreach commented Apr 9, 2024

We can keep discussing this for years... and fiddling with it back and forth..or just wait for niantic to do something that would need an update here and change it then 😉

@nexushoratio nexushoratio deleted the url-fix branch April 9, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permalink and Portal link are different than stock intel
3 participants