Fix performance drop when displaying a large number of ornaments

[modos189]

Fix #143: draw on canvas (instead of multiple markers) with Leaflet.Canvas-Markers (forked from https://github.com/Spaction/Leaflet.Canvas-Markers)

[johnd0e]

But to test it thoroughly we need to wait next Niantic event

[modos189]

I don't think so, because types of ornaments have long been known and described in header of code/ornaments.js

[johnd0e]

It's not only about ornaments icons, bot more about new canvas markers (I have not tested it in time, and now ornaments gone)

Also I see in the PR uncommon leaflet usage patterns which I'd like to fix.

[modos189]

Other types of markers can be used for this purpose. For example, I found in Tokyo frackers that are active right now.
https://intel.ingress.com/intel?ll=35.709534,139.721353&z=19

Due to the fact that all types of markers are known, it is possible to replace icons for testing other layers.

up: Beacon here: https://intel.ingress.com/intel?ll=35.711199,139.781713&z=17

[johnd0e]

I found in Tokyo frackers that are active right now.

I would prefer to test it with conditions similar to those we saw yesterday: huge ornaments amount.

[johnd0e]

Please enable Issues section for https://github.com/IITC-CE/Leaflet.Canvas-Markers repo.

[modos189]

Add
portal.options.data.ornaments = ['ap4'];
before
if (portal.options.data.ornaments) {
to mark ALL portals as clusters

[modos189]

Please enable Issues section for https://github.com/IITC-CE/Leaflet.Canvas-Markers repo.

done

[johnd0e]

Add portal.options.data.ornaments = ['ap4'];

See screenshot:

More than a half of map is without ornaments.
How to reproduce: make narrow window, reload IITC, then maximize window.

P.S. May be better discuss it in corresponding repo.

[modos189]

I added canvasIconLayer to LayerGroup() because no all functions are implemented. Disable the layer and reload the page. The layer will be enabled again.

[johnd0e]

I added canvasIconLayer to LayerGroup() because no all functions are implemented.

So let`s implement all.

BTW, there are still errors in console:

Uncaught TypeError: Cannot read property '_leaflet_id' of undefined
    at <anonymous>:15322:15835
    at a (<anonymous>:15322:1327)
    at remove (<anonymous>:15322:3508)
    at NewClass._removeGeneric (<anonymous>:15322:15973)
    at NewClass.removeMarker (<anonymous>:15322:15790)
    at NewClass.removeLayer (<anonymous>:15322:15639)
    at <anonymous>:19710:34
    at Array.forEach (<anonymous>)
    at Object.window.ornaments.removePortal (<anonymous>:19707:37)
    at window.Render.deletePortalEntity (<anonymous>:18534:22)

Similar: IITC-CE/Leaflet.Canvas-Markers#8

I propose to include unminified plugin sources in order to debug such cases.

[modos189]

So let`s implement all.

Layers are turned on and off in this function. But I don't know how to implement support.

ingress-intel-total-conversion/code/boot.js

Lines 541 to 565 in 256f9c5

	window.layerChooser.showLayer = function(id,show) {
	if (show === undefined) show = true;
	obj = this._layers[id];
	if (!obj) return false;
	if(show) {
	if (!this._map.hasLayer(obj.layer)) {
	//the layer to show is not currently active
	this._map.addLayer(obj.layer);
	//if it's a base layer, remove any others
	if (!obj.overlay) {
	for(i in this._layers) {
	if (i != id) {
	var other = this._layers[i];
	if (!other.overlay && this._map.hasLayer(other.layer)) this._map.removeLayer(other.layer);
	}
	}
	}
	}
	} else {
	if (this._map.hasLayer(obj.layer)) {
	this._map.removeLayer(obj.layer);
	}
	}

[johnd0e]

Layers are turned on and off in this function. But I don't know how to implement support.

I suppose it's a matter of events support.
E.g. layer.on('remove',function () { alert() }) should work with every leaflet layer.

[johnd0e]

Ok, I've found the source of our issue: https://github.com/Spaction/Leaflet.Canvas-Markers/blob/master/src/plugin/leaflet.canvas-markers.js#L270

Perhaps that was implemented wrong.
If we comment out this method then our layer keep it's state after page reload.

[johnd0e]

@modos189
Please check if you are OK with latest refactoring
(this PR is not best place for such things, so later I am going to rebase it)

[modos189]

Looks good. We also need to add links to new libraries in ATTRIBUTION.md

[johnd0e]

Branch rewritten!

Will update ATTRIBUTION.md after #134

Todo: finish https://github.com/IITC-CE/Leaflet.Canvas-Markers/

[modos189]

Looks like some kind of change was lost in rewrite process: ReferenceError: module is not defined

[johnd0e]

boot.js wasn't staged for last commit. I will fix it tomorrow

[modos189]

I'll have to wait, couldn't fix it(

[johnd0e]

See boot.js here aa9fea5

[johnd0e]

Look to the intel with DevTools.
And you see that this PR is far from ready(

Edit
I've fixed several errors.

[modos189]

So, what does it take to complete this PR?

[johnd0e]

IITC-CE/Leaflet.Canvas-Markers@71eab75#commitcomment-33502466