Player activity tracker: refactoring #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
xscreach
approved these changes
Oct 26, 2024
… timestamps (in milliseconds) as a string.
modos189
force-pushed
the
feature/extend-player-tracker-plugins
branch
from
78f3307
to
3afb6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at what changes the Player Tracker add-on was making and updated the Player activity tracker code at some points. This was to use this add-on as an example to make it easier for other plugins to make changes to Player activity tracker. On the other hand, I made only those changes that will not be unnecessary in our code base.
What's done:
agofunction has been moved towindow.formatAgoand has more possibilities, tests for the function have been writtenpolyLineByAgeEnlandpolyLineByAgeResthepolyLineByPlayerAndAgeis used, specifying the player's name.window.PLAYER_TRACKER_MAX_DISPLAY_EVENTSvariable containing the maximum number of displayed actionswindow.plugin.playerTracker.getDrawnTracesByTeamfunction to refer to layersThese changes should not affect the plugin's functionality, but will simplify the development of third-party plugins that use Player activity tracker