Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins/Language: 43587, return path in public folder from ilPluginSlotInfo #8837

Open
wants to merge 2 commits into
base: release_10
Choose a base branch
from

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Jan 14, 2025

@klees klees self-assigned this Jan 14, 2025
@klees klees added the bugfix label Jan 14, 2025
Copy link
Member

@klees klees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nhaagen,

thanks a lot for looking into this. I'm a little anxious that this damages other functionality, since we change that base path. Did you check:

  • Where ilComponentRepository::PLUGIN_BASE_PATH is used overall?
  • Where ilPluginSlotInfo::getPath is used?
  • I any test plugin keeps working after this change?

If all "yes": Phew 😅 If not: Please check and report back. Thanks!

Kind regards!

@nhaagen
Copy link
Contributor Author

nhaagen commented Jan 15, 2025

I was reluctant, too, and then had to remove the "public/" part in ilPluginLanguage (see the first comimt of this PR)
In the according ticket, @christof756 pointed to some other misbehavior, and I changed the constant.

PLUGIN_BASE_PATH is really being used by ilPluginSlotInfo only, and ilPluginSlotInfo::getPath ist sort of hard to trace: It's used by ilPluginInfo, and that is involved every time the plugin is accessed.
However, TestSetupPlugin and EditorAsMode both work fine with the changes suggested here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants