Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Incorrect design of quotes used in Testimonials #5 #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

disvid
Copy link
Collaborator

@disvid disvid commented Dec 18, 2024

Related Issue

Closes #5

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

fixes- the quotes which are used in user reviews in the Testimonials section are incorrect.

Implementation Details

As similar icon not available on FontAwesome, I downloaded it as png from figma and updated the HTML code.

Demo

Screenshot (7)

@Yash-g2310
Copy link
Collaborator

@disvid please match the design with figma design it is not the same

@disvid
Copy link
Collaborator Author

disvid commented Dec 20, 2024

I have taken the image from figma itself. pls see below.
this is figma:
Screenshot from 2024-12-21 00-21-06
this is my edit:
Screenshot from 2024-12-21 00-21-20

@Yash-g2310
Copy link
Collaborator

Yash-g2310 commented Jan 5, 2025

@disvid i meant to say, the size and the alignment of the image (the semicolons) is not proper as you can see in the 2 ss you provided, please correct it accordingly

@sasmitaditya13
Copy link
Collaborator

@disvid Please correct it by today or Ill close the PR

@disvid
Copy link
Collaborator Author

disvid commented Jan 8, 2025

@sasmitaditya13 @Yash-g2310 done sir, the corrections have been made, sorry for the delay.

@sasmitaditya13
Copy link
Collaborator

@Yash-g2310 Check the responsiveness

@Yash-g2310
Copy link
Collaborator

@disvid
image
image
as you can see above, the positioning of the semicolon is not responsive
below are screen widths for ss where they are observed

  1. =1124px
    2.. >=720px

please correct it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect design of quotes used in Testimonials
3 participants