Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes issue #63 #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MadhavDhall
Copy link

Closes issue #63

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

The Navbar color in the home page is now same as in the design intended in figma file. Also Try It Out button is now also according to style required.

Implementation Details

I have updated index.html file and landingpage.css file in resources/css folder. Updated the style and html file and added correct background color and appropriate display for elements in navbar section to arrange as desired and become responsive. Also i deleted unnecessary elements and styles which were harming responsive and clean navbar. These deletions and additions have no side effect on the functioning of the web page.

Demo

Provide screenshots or a video demonstrating the feature in action.
(Include attachments or links, if applicable.)
Screenshot 2024-12-22 at 12 37 17 AM
Screenshot 2024-12-22 at 12 37 13 AM
Screenshot 2024-12-22 at 12 36 50 AM

@Yash-g2310
Copy link
Collaborator

@MadhavDhall
there are some issues
image
this requires padding in y drxn, also verify the padding in x is same as figma

get in mobile view and click the hamburger menu, we need to click it twice to open it, and after closing the hamburger menu and going back to desktop view,
image
the content of the navbar vanishes

also taking the try us out was mentioned in #14 so you can add the code for it in different pr, please do the required changes so that we can merge the code

here is the figma link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants