Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Navbar sticky #83 #93

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

Sanat-Jha
Copy link
Collaborator

Related Issue

Closes #83

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature

Description of Change

A sticky navbar is more easily accessible. So just made the navbar sticky.

Demo

Recording.2025-01-10.181730.mp4

@sasmitaditya13
Copy link
Collaborator

@Sanat-Jha Resolve the conflicts, I will be merging this.

@Sanat-Jha
Copy link
Collaborator Author

@sasmitaditya13 resolved.

@sasmitaditya13 sasmitaditya13 merged commit 3c27b37 into IMGIITRoorkee:main Jan 15, 2025
@sasmitaditya13
Copy link
Collaborator

@Sanat-Jha remove sticky from the mobile view and raise a PR for that

@Sanat-Jha
Copy link
Collaborator Author

Sanat-Jha commented Jan 15, 2025

@sasmitaditya13 I have removed it from mobile view but unable to push it in this PR as its already merged and closed.
Also, same set of css is making it sticky on all devices and additional media queries will be written just to remove it from mobile and then in new PR i will have to remove these media queries again, which isn't really meaningful. What should I continue with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature - Sticky Navbar
2 participants