Settings Management #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly mention the issue you are trying to address as well. |
|
@TanmayArya-1p please mention which issue this pr closes and if it is a new feature you proposed , first raise a issue. |
|
@fillingtothemomo I have created the issue( #66 ) and mentioned it in the PR |
|
@TanmayArya-1p thanks for working on this, however, i don't see a grave need for this feature especially when it makes a huge change and would meddle with other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Issue #66
Type of Change
Different parts of the program can now store static settings using the
SettingsManagerobject created inmain.py. the settings are stored inconfig.jsonin the form of string:string key value pairs.config.jsonis structured to have auser-definedsection which the user can edit and aapplicationsection which can be used for more permanent settings.Other people can now use this for storing their configuration options inside the program.
Also the user can edit the
user-definedsettings using the settings prompt:Here the user can temporarily edit the string:string key value pairs and choose to save changes or revert back to the config before the changes were made. Alternatively the user can also load settings from a URL allowing for config sharing between users.