Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force overwrite of docker images in github actions #854

Closed
prasadtalasila opened this issue Jul 4, 2024 · 4 comments · Fixed by #926
Closed

Force overwrite of docker images in github actions #854

prasadtalasila opened this issue Jul 4, 2024 · 4 comments · Fixed by #926
Assignees
Labels
bug Something isn't working

Comments

@prasadtalasila
Copy link
Contributor

The github actions are supposed to publish only new versions of packages. This behavior is observed in npm packages but not docker images. In the case of docker images, all the commits to client/ or servers/lib of feature/distributed-demo branch result in overwrite of existing images. This behavior is undesirable.

@prasadtalasila prasadtalasila added the bug Something isn't working label Jul 4, 2024
@nichlaes
Copy link
Collaborator

@prasadtalasila can you describe a bit more in depth, what the desired behavior is?

@prasadtalasila
Copy link
Contributor Author

prasadtalasila commented Sep 19, 2024

@nichlaes
If the same version of docker image is already in the github container image registry, github actions must skip the docker image publication.

@prasadtalasila
Copy link
Contributor Author

@nichlaes
This github action does not go to docker image publishing unless the npm publishing is successful. Does lib-ms.yml has the problem described in this issue?

@prasadtalasila
Copy link
Contributor Author

@nichlaes This github action does not go to docker image publishing unless the npm publishing is successful. Does lib-ms.yml has the problem described in this issue?

The docker publication job in the lib-ms depends on npm-publish-package job and this workflow graph shows the dependence clearly. Thus an npm package publish fails, docker image publish also fails. So it is not a problem for lib-ms package.

The problem is with the client. The docker publication job in the client only depends on the successful running of the tests.
This workflow graph of client shows the problem clearly. If the tests are successful, docker image is either newly published or existing image rewritten.

The PR can be confirmed by checking the result on the client docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants