Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only publish docker image if version is not yet published #926

Conversation

nichlaes
Copy link
Collaborator

No description provided.

@nichlaes nichlaes linked an issue Sep 19, 2024 that may be closed by this pull request
@nichlaes
Copy link
Collaborator Author

@prasadtalasila this should fix the #854

@prasadtalasila
Copy link
Contributor

@nichlaes can you make a minor correction in client or servers/lib directory and see if this is enforced? Or is there an easy way to check the functioning of this PR?

@prasadtalasila
Copy link
Contributor

The client/config/dev.js requires correction. The updated content of this file is:

if (typeof window !== 'undefined') {
  window.env = {
    REACT_APP_ENVIRONMENT: 'dev',
    REACT_APP_URL: 'http://localhost:4000/',
    REACT_APP_URL_BASENAME: '',
    REACT_APP_URL_DTLINK: '/lab',
    REACT_APP_URL_LIBLINK: '',
    REACT_APP_WORKBENCHLINK_VNCDESKTOP: '/tools/vnc/?password=vncpassword',
    REACT_APP_WORKBENCHLINK_VSCODE: '/tools/vscode/',
    REACT_APP_WORKBENCHLINK_JUPYTERLAB: '/lab',
    REACT_APP_WORKBENCHLINK_JUPYTERNOTEBOOK: '',

    REACT_APP_CLIENT_ID: '1be55736756190b3ace4c2c4fb19bde386d1dcc748d20b47ea8cfb5935b8446c',
    REACT_APP_AUTH_AUTHORITY: 'https://gitlab.com/',
    REACT_APP_REDIRECT_URI: 'http://localhost:4000/Library',
    REACT_APP_LOGOUT_REDIRECT_URI: 'http://localhost:4000/',
    REACT_APP_GITLAB_SCOPES: 'openid profile read_user read_repository api',
  };
};

@prasadtalasila
Copy link
Contributor

The servers/lib/DEVELOPER.md requires correction in the following table.

| OS      | Absolute Path                 | Relative Path |
| ------- | ----------------------------- | ------------- |
| Windows | C:\DTaaS\files                | ..\..\files  |
| Linux   | /Users/\<Username\>/DTaaS/files | ../../files   |

@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Sep 20, 2024
Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nichlaes Please also check issue #854 for more recent explanation of the problem.

servers/lib/DEVELOPER.md Outdated Show resolved Hide resolved
client/config/dev.js Outdated Show resolved Hide resolved
@nichlaes
Copy link
Collaborator Author

@prasadtalasila I have reset the changes and tested it locally. Should we merge this and test it on the client?

Copy link

codeclimate bot commented Sep 23, 2024

Code Climate has analyzed commit 35de431 and detected 0 issues on this pull request.

View more on Code Climate.

@prasadtalasila prasadtalasila merged commit fe2ded9 into feature/distributed-demo Sep 23, 2024
11 checks passed
@prasadtalasila prasadtalasila deleted the 854-force-overwrite-of-docker-images-in-github-actions branch September 23, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Force overwrite of docker images in github actions
2 participants