Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-oidc-context does not permit the http scheme #899

Closed
aryanpingle opened this issue Sep 5, 2024 · 3 comments
Closed

react-oidc-context does not permit the http scheme #899

aryanpingle opened this issue Sep 5, 2024 · 3 comments
Assignees

Comments

@aryanpingle
Copy link
Contributor

As of now, DTaaS uses https://gitlab.com as an OAuth provider, which works with no problems.

With the ongoing effort to switch to an integrated GitLab instance (#892), if a DTaaS server is set up at http://site.com (note: http and not https) the local gitlab instance would be available at http://site.com/gitlab. However, the homepage "sign in with GitLab" button redirects to https://site.com/gitlab because of a known issue with oidc-client-ts that automatically uses https.

This might even break development servers at http://localhost for the same reason - I'll try it out and post it here.

@aryanpingle
Copy link
Contributor Author

Worth noting: Having OAuth on http kind of breaks the purpose of having authentication in the first place, as network requests aren't encrypted anymore. The most likely use case for this would be when you're setting up a DTaaS server and you haven't enabled TLS for your domain yet. Perhaps we could offer a setup option for the server to use gitlab.com instead of the path prefixed local instance?

@prasadtalasila
Copy link
Contributor

The PR #905 adds support for https://foo.com/gitlab. Let us have a similar setup for https://localhost/gitlab and close the issue.

@prasadtalasila
Copy link
Contributor

The problem is beyond the purview of this project. An explanation has been added in PR #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants