Add path prefixed gitlab-ce instance #905
Conversation
There was a problem hiding this comment.
@aryanpingle thanks for the PR. Please check the comments. Given that this compose file is only useful with a properly working OAuth setup, please include those changes in this PR as well.
* Make https url scheme mandatory for gitlab instance (due to react-oidc) * Hardcode gitlab image for consistency with tests
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Please add INTEGRATION.md detailing the steps required for integrating gitlab with the rest of DTaaS installation. It is a three step process
|
|
@aryanpingle |
|
Can confirm, authorization fails with a self-signed/invalid certificate (OAuth2 redirect results in |
There was a problem hiding this comment.
@aryanpingle
In step-1, the DTaaS without any valid OAuth applications. In step-3, these OAuth applications are created on https://foo.com/gitlab. This instance is used to create valid OAuth applications. New step-4 configures DTaaS application again with valid OAuth applications.
In addition, the post-install instructions seem wrong. Please check.
There was a problem hiding this comment.
Ah right, I'll correct the steps. Which post-install instruction are you referring to sir?
| > The section "Add TLS Certificates (Optional)" should be treated as | ||
| > mandatory for now, to ensure `react-oidc-context` correctly redirects users | ||
| > for authorization. | ||
|
Code Climate has analyzed commit c8b40f6 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
PR to address #892 and #899