887 upgrade dependencies of libms #943

nichlaes · 2024-09-23T12:29:58Z

Updates all dependabots suggestions

codeclimate

The PR diff size of 5562 lines exceeds the maximum allowed for the inline comments feature.

prasadtalasila · 2024-09-25T09:35:15Z

@nichlaes I have migrated the eslint config to javascript equivalent of it in this PR. The actual file is here

codeclimate

The PR diff size of 5620 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5673 lines exceeds the maximum allowed for the inline comments feature.

prasadtalasila · 2024-09-27T06:41:38Z

@nichlaes please see the eslint config in PR #945 for another working stack

codeclimate

The PR diff size of 5127 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5243 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5301 lines exceeds the maximum allowed for the inline comments feature.

nichlaes · 2024-10-03T12:30:13Z

@prasadtalasila I should have fixed the problem.

I investigated further and found a Github Issue with people having the same problem. Changing the moduleNameMapper in the jest.config.ts seemed to do the trick. It should support relative paths now

prasadtalasila

@nichlaes Thanks for the updates. Please see the comments.

servers/lib/package.json

client/yarn.lock

servers/lib/package.json

prasadtalasila · 2024-10-03T14:37:49Z

servers/lib/package.json

-    "start": "node dist/src/main.js",
-    "start:pm2": "pm2 start pm2.config.js",
+    "start": "tsc & node dist/src/main.js",
+    "start:pm2": "pm2 start pm2.config.cjs",
    "stop:pm2": "pm2 delete libms",
    "syntax": "eslint . --fix",


Gives the following error (only on Windows):

$ yarn syntax yarn run v1.22.19 $ eslint . --fix Oops! Something went wrong! :( ESLint: 9.11.1 ConfigError: Config (unnamed): Unexpected key "0" found. at rethrowConfigError (C:\Users\user\git\DTaaS\servers\lib\node_modules\@eslint\config-array\dist\cjs\index.cjs:303:8) at C:\Users\user\git\DTaaS\servers\lib\node_modules\@eslint\config-array\dist\cjs\index.cjs:1098:5 at Array.reduce (<anonymous>) at FlatConfigArray.getConfigWithStatus (C:\Users\user\git\DTaaS\servers\lib\node_modules\@eslint\config-array\dist\cjs\index.cjs:1091:43) at FlatConfigArray.getConfig (C:\Users\user\git\DTaaS\servers\lib\node_modules\@eslint\config-array\dist\cjs\index.cjs:1120:15) at C:\Users\user\git\DTaaS\servers\lib\node_modules\eslint\lib\eslint\eslint-helpers.js:354:54 at C:\Users\user\git\DTaaS\servers\lib\node_modules\eslint\lib\eslint\eslint-helpers.js:296:32 at Object.isAppliedFilter (C:\Users\user\git\DTaaS\servers\lib\node_modules\@nodelib\fs.walk\out\readers\common.js:12:31) at AsyncReader._handleEntry (C:\Users\user\git\DTaaS\servers\lib\node_modules\@nodelib\fs.walk\out\readers\async.js:86:20) at C:\Users\user\git\DTaaS\servers\lib\node_modules\@nodelib\fs.walk\out\readers\async.js:65:22 error Command failed with exit code 2.

I don't get that error

prasadtalasila · 2024-10-03T14:40:23Z

servers/lib/test/e2e/app.e2e.spec.ts

-  InMemoryCache,
-  gql,
-} from '@apollo/client';
+import { ApolloClient, DocumentNode, InMemoryCache, gql} from "@apollo/client/core/core.cjs";


can we import esm modules of the library with mjs extension?

I had to change it, since @apollo client isn't esm yet

servers/lib/tsconfig.json

codeclimate

The PR diff size of 5230 lines exceeds the maximum allowed for the inline comments feature.

codecov · 2024-10-04T08:58:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (eaa22d5) to head (65a6182).
Report is 31 commits behind head on feature/distributed-demo.

❗ Current head 65a6182 differs from pull request most recent head 4f8bc11

Please upload reports for the commit 4f8bc11 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (eaa22d5) and HEAD (65a6182). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (eaa22d5) HEAD (65a6182)

client-unit-integration-tests 1 0

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/distributed-demo    #943       +/-   ##
============================================================
- Coverage                     66.49%   0.00%   -66.50%     
============================================================
  Files                            31       6       -25     
  Lines                           394      88      -306     
  Branches                         26       3       -23     
============================================================
- Hits                            262       0      -262     
+ Misses                          117      85       -32     
+ Partials                         15       3       -12

Files with missing lines	Coverage Δ
servers/lib/src/cloudcmd/cloudcmd.ts	`0.00% <ø> (ø)`
servers/lib/src/files/files.module.ts	`0.00% <ø> (ø)`
servers/lib/src/files/resolvers/files.resolver.ts	`0.00% <ø> (ø)`
...rs/lib/src/files/services/files-service.factory.ts	`0.00% <ø> (ø)`
...vers/lib/src/files/services/local-files.service.ts	`0.00% <ø> (ø)`

... and 31 files with indirect coverage changes

Components	Coverage Δ
Website	`∅ <ø> (∅)`
Lib Microservice	`0.00% <ø> (∅)`

codeclimate

The PR diff size of 5222 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5267 lines exceeds the maximum allowed for the inline comments feature.

nichlaes · 2024-10-04T09:26:30Z

@prasadtalasila Please have a look again. It should be good now.

codeclimate

The PR diff size of 5272 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5287 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2024-10-08T08:49:11Z

Code Climate has analyzed commit 4f8bc11 and detected 0 issues on this pull request.

View more on Code Climate.

nichlaes added 19 commits September 23, 2024 13:49

resolves #942

3024943

resolves #941

b1a2933

updated lock

50d2162

resolves #940

1796cb8

resolves #939

2f9a5b3

resolves #938

3d81b00

updated lock

5499e12

resolves #937

b19b0ad

resolves #936

bc430ed

resolves #935

4a1e55b

resolves #934

03ee3fb

resolves #933

b2c3fb1

updated lock

82766c3

resolves #932

ee172a7

resolves #931

133fd70

resolves #930

5629497

resolves #929

96813ca

resolves #928

699c285

updated lock

ea25350

nichlaes requested a review from prasadtalasila September 23, 2024 12:29

nichlaes linked an issue Sep 23, 2024 that may be closed by this pull request

Upgrade dependencies of libms #887

Closed

updated packages

2c6540c

codeclimate bot reviewed Sep 25, 2024

View reviewed changes

migrates to flat config file

40606df

codeclimate bot reviewed Sep 26, 2024

View reviewed changes

no longer supported

88922ef

codeclimate bot reviewed Sep 26, 2024

View reviewed changes

fixed eslint errors

7ddcadd

revert changes to runner

bd935a8

codeclimate bot reviewed Sep 27, 2024

View reviewed changes

nichlaes added 4 commits September 30, 2024 14:44

renamed eslint file

8680bcd

renamed

3ad2a72

changed to module

344150c

updated config files

ae93e55

codeclimate bot reviewed Oct 2, 2024

View reviewed changes

nichlaes added 3 commits October 3, 2024 11:41

renamed config

bb58e4b

updates configuration

cd35cd3

remove deprecated version field

ab18ae7

codeclimate bot reviewed Oct 3, 2024

View reviewed changes

prasadtalasila reviewed Oct 3, 2024

View reviewed changes

Revert updated lock This reverts commit 50d2162.

65a6182

codeclimate bot reviewed Oct 4, 2024

View reviewed changes

Revert updated lock

99a2883

codeclimate bot reviewed Oct 4, 2024

View reviewed changes

nichlaes added 3 commits October 4, 2024 11:21

update packages

906b06a

update package lock

9d12717

update config

9dbb9b9

codeclimate bot reviewed Oct 4, 2024

View reviewed changes

adds os matrix

897f774

codeclimate bot reviewed Oct 8, 2024

View reviewed changes

adds seperate checks for windows and linux

4f8bc11

codeclimate bot reviewed Oct 8, 2024

View reviewed changes

prasadtalasila merged commit 8313de1 into feature/distributed-demo Oct 8, 2024
9 checks passed

prasadtalasila deleted the 887-upgrade-dependencies-of-libms branch October 8, 2024 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

887 upgrade dependencies of libms #943

887 upgrade dependencies of libms #943

nichlaes commented Sep 23, 2024

codeclimate bot left a comment

prasadtalasila commented Sep 25, 2024

codeclimate bot left a comment

codeclimate bot left a comment

prasadtalasila commented Sep 27, 2024

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

nichlaes commented Oct 3, 2024

prasadtalasila left a comment

prasadtalasila Oct 3, 2024

nichlaes Oct 4, 2024

prasadtalasila Oct 3, 2024

nichlaes Oct 4, 2024

codeclimate bot left a comment

codecov bot commented Oct 4, 2024 •

edited

Loading

codeclimate bot left a comment

codeclimate bot left a comment

nichlaes commented Oct 4, 2024

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot commented Oct 8, 2024

887 upgrade dependencies of libms #943

887 upgrade dependencies of libms #943

Conversation

nichlaes commented Sep 23, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

prasadtalasila commented Sep 25, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

prasadtalasila commented Sep 27, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

nichlaes commented Oct 3, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Oct 3, 2024

Choose a reason for hiding this comment

nichlaes Oct 4, 2024

Choose a reason for hiding this comment

prasadtalasila Oct 3, 2024

Choose a reason for hiding this comment

nichlaes Oct 4, 2024

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

nichlaes commented Oct 4, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 8, 2024

codecov bot commented Oct 4, 2024 •

edited

Loading