Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/irnas zephyr template migration #9

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

NejcKle
Copy link
Contributor

@NejcKle NejcKle commented Dec 13, 2023

Description

This PR implements changes required to migrate the workflow files and scripts from the irnas-runners-software repository to this one and irnas-zephyr-tempalte. Some files got moved around and/or to different repositories, see Related below.

Changes:

  • Workflow files have been modified to run on self-hosted runners.
  • Remote Raspberry Pi Twister runner workflow has been added.
  • Docs have been updated.

Closes #

Related https://github.com/IRNAS/irnas-runners-software/pull/6 IRNAS/irnas-zephyr-template#14

Areas of interest for the reviewer

Check the workflow files and docs.

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed
    functions.
  • I updated all customer-facing technical documentation.

After-review steps

  • Reviewer can merge and delete the branch.

@github-actions github-actions bot added the pull request Pull request, added automatically by CI. label Dec 13, 2023
Copy link
Collaborator

@MarkoSagadin MarkoSagadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have marked some minor things

workflow-templates/zephyr/README.md Outdated Show resolved Hide resolved
- [Required GitHub action secrets](#required-github-action-secrets)
- [General secrets](#general-secrets)
- [CodeChecker specific secrets](#codechecker-specific-secrets)
- [Zephyr](#zephyr)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this line was added (maybe the TOC plugin in the VSCode does that?) Please remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the <!-- omit in toc --> comment to omit it from the table

@MarkoSagadin
Copy link
Collaborator

@NejcKle I have approved the PR. Before merging please rebase your last three commits into original three to keep the git history clean.

@NejcKle NejcKle force-pushed the feature/irnas-zephyr-template-migration branch from 4de1c18 to 688218a Compare December 20, 2023 11:06
@NejcKle NejcKle merged commit 04d6181 into main Dec 20, 2023
@NejcKle NejcKle deleted the feature/irnas-zephyr-template-migration branch December 20, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request Pull request, added automatically by CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants