-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/irnas zephyr template migration #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have marked some minor things
workflow-templates/zephyr/README.md
Outdated
- [Required GitHub action secrets](#required-github-action-secrets) | ||
- [General secrets](#general-secrets) | ||
- [CodeChecker specific secrets](#codechecker-specific-secrets) | ||
- [Zephyr](#zephyr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this line was added (maybe the TOC plugin in the VSCode does that?) Please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the <!-- omit in toc -->
comment to omit it from the table
@NejcKle I have approved the PR. Before merging please rebase your last three commits into original three to keep the git history clean. |
4de1c18
to
688218a
Compare
Description
This PR implements changes required to migrate the workflow files and scripts from the
irnas-runners-software
repository to this one andirnas-zephyr-tempalte
. Some files got moved around and/or to different repositories, see Related below.Changes:
Closes #
Related https://github.com/IRNAS/irnas-runners-software/pull/6 IRNAS/irnas-zephyr-template#14
Areas of interest for the reviewer
Check the workflow files and docs.
Checklist
functions.
I updated all customer-facing technical documentation.After-review steps