Issue 511 #514
Merged
Issue 511 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serialized in isatab2json conversion
The response[0] in core was setting what was supposed to be a list to a single string from the list instead. The check for whether a ontology source was in the list was nested beneath another check instead of being its own check.
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
terazus
reviewed
Feb 12, 2024
Fairly significant changes to check_protocol_fields
Changed messaging on study assays errors
Extended 511
The problem with trying to do this is that some of the protocol types in the yaml file have "Sample Name" and "Extract Name" as the headers and this causes those headers to be added multiple times. It might be better to leave those empty. Also might be good to change headers to a list to get rid of the special case for "nucleic acid hybridization".
For some reason the bottom part of the function only logged errors and did not add them to the validator dictionary. They also did not indicate which filename the error was from, so tracking down where the problem is was difficult. This might just be an oversight since the warnings at the top of the function were just fine.
Added better messaging
Refactor isatab loader
Protocol types refactor
knirirr
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue 511 and issue 512.