Hotfix/retina screen #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oth ones when the mesh contains more vertices than normals (volume meshes): we were checking if the vertex index is lower or equal than the number of normals which is not true for volume mesh. The test is removed but I add an assert to check that the normal index at vertex is lower or equal to the number of normals.
…le pixel values which are passed to openGL functions. It allows to use Medit on recent Mac-OSX screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix (at least partially) issue #6 :
-rcommand line option allow to enable hdpi retina screen support (we doble pixel sizes if needed by the openGL function).I have tested:
Possible improvement: I haven't succeed to automatically compute the pixel density using current Medit dependencies (it is possible using cocoa or glfw libraries) so high pixel density is manually enabled with the
-roption.Known issue :
- passing a window from a retina screen to a non retina one (or invert) don't work (it would work with automatic computation of pixel density).