Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WDAS #1000

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add WDAS #1000

wants to merge 3 commits into from

Conversation

radford-for-smpte
Copy link
Collaborator

closes #999

Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • need to rev schema
  • need to check on the main reflector if the >3 character code will not break implementations

@SteveLLamb
Copy link
Collaborator

Note for myself to rev the HTML generation pages on https://github.com/ISDCF/registries-site for facilities when this is complete.

@palemieux
Copy link
Contributor

@radford-for-smpte Can you coordinate with @japierce1028 to ask the question on the reflector?

@japierce1028
Copy link
Collaborator

I think this should be an issue, not an issue as part of this PR. I would like a discussion on the need to have 4 characters. The 3 character limit is not broken and I'm not convinced that we need to fix it.

@radford-for-smpte
Copy link
Collaborator Author

I think this should be an issue, not an issue as part of this PR. I would like a discussion on the need to have 4 characters. The 3 character limit is not broken and I'm not convinced that we need to fix it.

There already is an issue (#999) filed, but I agree based on the direction this discussion is going we should probably move it over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Disney Animation as a Facility
4 participants