Skip to content

Commit

Permalink
Use macOS 14 in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ISSOtm committed Aug 8, 2024
1 parent 817dcfd commit 7d1208e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/install_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ case "${1%-*}" in
macos)
brew install bison libpng pkg-config md5sha1sum
# For the version check below exclusively, re-do this before building
export PATH="/usr/local/opt/bison/bin:$PATH"
export PATH="/opt/homebrew/opt/bison/bin:/usr/local/opt/bison/bin:$PATH"
;;
*)
echo "WARNING: Cannot install deps for OS '$1'"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-release-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
path: rgbds-${{ env.version }}-win${{ matrix.bits }}.zip

macos:
runs-on: macos-12
runs-on: macos-14
steps:
- name: Get version from tag
shell: bash
Expand Down
17 changes: 6 additions & 11 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ jobs:
unix:
strategy:
matrix:
os: [ubuntu-20.04, ubuntu-22.04, macos-12]
os: [ubuntu-20.04, ubuntu-22.04, macos-14]
cxx: [g++, clang++]
buildsys: [make, cmake]
exclude:
# Don't use `g++` on macOS; it's just an alias to `clang++`.
- os: macos-12
- os: macos-14
cxx: g++
fail-fast: false
runs-on: ${{ matrix.os }}
Expand All @@ -27,13 +27,13 @@ jobs:
- name: Build & install using Make
if: matrix.buildsys == 'make'
run: |
export PATH="/usr/local/opt/bison/bin:$PATH"
export PATH="/opt/homebrew/opt/bison/bin:/usr/local/opt/bison/bin:$PATH"
make develop -kj Q= CXX=${{ matrix.cxx }}
sudo make install -j Q=
- name: Build & install using CMake
if: matrix.buildsys == 'cmake'
run: |
export PATH="/usr/local/opt/bison/bin:$PATH"
export PATH="/opt/homebrew/opt/bison/bin:/usr/local/opt/bison/bin:$PATH"
cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} -DSANITIZERS=ON -DMORE_WARNINGS=ON
cmake --build build -j --verbose
cp build/src/rgb{asm,link,fix,gfx} .
Expand Down Expand Up @@ -77,12 +77,7 @@ jobs:
test/run-tests.sh
macos-static:
strategy:
matrix:
# Don't run on macOS 11; our setup makes clang segfault (YES).
os: [macos-12]
fail-fast: false
runs-on: ${{ matrix.os }}
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- name: Install deps
Expand All @@ -94,7 +89,7 @@ jobs:
# even support `-Wall`...).
- name: Build & install
run: |
export PATH="/usr/local/opt/bison/bin:$PATH"
export PATH="/opt/homebrew/opt/bison/bin:/usr/local/opt/bison/bin:$PATH"
make -kj CXXFLAGS="-O3 -flto -DNDEBUG -mmacosx-version-min=10.9" PKG_CONFIG="pkg-config --static" PNGLDLIBS="$(pkg-config --static --libs-only-L libpng | cut -c 3-)/libpng.a $(pkg-config --static --libs-only-l libpng | sed s/-lpng[0-9]*//g)" Q=
- name: Package binaries
run: |
Expand Down
5 changes: 4 additions & 1 deletion test/fetch-test-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ case "$actionname" in
# libbet depends on PIL to build
if [ "$2" = "libbet" ]; then
case "${osname%-*}" in
ubuntu|macos)
macos)
python3 -m pip install --break-system-packages pillow
;;
ubuntu)
python3 -m pip install pillow
;;
windows)
Expand Down

0 comments on commit 7d1208e

Please sign in to comment.