-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox Phase 2 - Java Container Feature#568h #592
Open
danidiazd
wants to merge
159
commits into
develop
Choose a base branch
from
feature#568h
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,111
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # itachallenge-score/src/main/java/com/itachallenge/score/controller/ScoreController.java # itachallenge-score/src/main/java/com/itachallenge/score/document/Score.java # itachallenge-score/src/test/java/com/itachallenge/score/controller/ScoreControllerTest.java # itachallenge-score/src/test/java/com/itachallenge/score/repository/IScoreRepositoryTest.java
… mds to refactor image used in the sandbox and explain, restrictive.policy
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
- Implemented a Chain of Responsibility with the following filters:
- Created the DockerExecutor class
The DockerExecutor is responsible for launching a Docker container with a Java image to execute the user's code. It includes a method to terminate the container in case of issues such as infinite loops, and implements AutoCloseable to ensure proper resource management.
Used a openjdk:11-slim and apply a restrictive.policy to more security.
- Created the CodeProcessingManager class
The CodeProcessingManager manages the entire flow of processing user code. It first applies the chain of filters to validate the code, and if the filters pass, it invokes DockerExecutor to execute the code within a container. After execution, it performs the following steps to calculate the score:
Compilation Check: Verifies if the code compiled successfully.
Execution Check: Verifies if the code executed without errors.
Result Comparison: Compares the execution result with the expected output. The scoring logic handles different levels of accuracy:
Finally, it generates a ScoreResponse based on these checks and returns it to the controller.