[BE] Fix Forget Password Endpoint#87 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the message of the error
…UserController.php
|
Hi, Eduard. First of all, thanks for your magnificent job cleaning the code that you received. We really appreciate that. Then, step by step:
Very good job, Eduard!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
app.php: delete duplicate routes for 'forget password' feature.ForgetController.php: deleted since its only method 'forgetPassword' is duplicated inUserController.php.UserController.php: UpdatedforgetPasswordmethodHttp\Mail\ForgetMail.php: corrected public var $token and added user name var, both to be used inside email contentApp\Exceptions\Handler.php: added validation error handling to send response containing the message of the errorresources/views/mail/forget.blade.php:(1) replaced text 'company name' by 'IT Academy Landing', (2) Added user name after 'Hello', (3) Changed Reset Button alignment from left to center, (4) corrected reset password link to call the right methodRenamed file names to make them more understandable:
forget.badae.php-> forgetPassword.blade.phpforgetMail.php-> forgetPasswordMail.phpHttp\Requests\ResetRequest.php: updated password rules to match those in store process (register) of UserController.phpScreenshot: