Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api)!: remove student modality endpoint #283

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivanlegranbizarro
Copy link
Collaborator

@ivanlegranbizarro ivanlegranbizarro commented Oct 3, 2024

FRONTEND VIOLATION:

En backend hemos quitado este endpoint ('http://localhost:8000/api/v1/student/${studentId}/resume/modality) porque la información de modality tiene más sentido integrarla dentro del Resume del Student. Eso afecta al frontend.
Hablo con los compañeros de frontend y me dan permiso para corregir la petición de axios.

Antes:
peticionAxios

Ahora:
frontendViolation

@ivanlegranbizarro ivanlegranbizarro added the Dreaming of a better world Changes you want to implement to make your project better label Oct 3, 2024
@ivanlegranbizarro ivanlegranbizarro self-assigned this Oct 3, 2024
@ivanlegranbizarro ivanlegranbizarro linked an issue Oct 3, 2024 that may be closed by this pull request
@ivanlegranbizarro ivanlegranbizarro force-pushed the 280-be-refactor-studentmodality-endpoint branch 3 times, most recently from 3b00dd5 to ccb47ab Compare October 3, 2024 15:47
@ivanlegranbizarro ivanlegranbizarro force-pushed the 280-be-refactor-studentmodality-endpoint branch from 710d3d6 to 94d7d59 Compare October 3, 2024 15:59
Copy link
Collaborator

@jordimorillo jordimorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the missing part of frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dreaming of a better world Changes you want to implement to make your project better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Refactor: 'student.modality' Endpoint
2 participants