274 be refactor model binding student languages endpoint #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factored StudentLanguageDetailControllerTest and the endpoint parameter name were refactored according to model binding
LanguageResource and LanguageCollection were created for StudentLanguagesDetailController
… deleted StudentLanguagesDetailController was refactored and StudentLanguageDetailService and itst tests: StudentLanguageDetailServiceTest were deleted according to Model binding structure
…nd change output messages
…source:' in controller LanguageResource was deleted and syntax annotation 'resource:' in StudentLanguagesDetailController
…into 274-be-refactor-model_binding-student_languages-endpoint
diegdar
requested review from
jordimorillo,
StephaneCarteaux,
ivanlegranbizarro,
nachoa88 and
begoIT24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to apply Model Binding to the GET student.languages endpoint