[백지현] 1차 과제 제출 #11
Open
[백지현] 1차 과제 제출 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u-genuine
reviewed
Oct 6, 2024
| } | ||
| } | ||
|
|
||
| private void decreaseSellIn(Item item) { |
There was a problem hiding this comment.
decreaseSellIn 메서드랑 increaseQuality 메서드가 중복되니 부모 클래스에 구현하고 자식클래스에서 상속받아서 사용해도 좋을 것 같습니다 😊
| } | ||
| } | ||
| } | ||
| for (Item item : items) { |
gikhoon
reviewed
Oct 7, 2024
| } | ||
| } | ||
| for (Item item : items) { | ||
| Logic logic = LogicFactory.getLogic(item); |
There was a problem hiding this comment.
팩토리 메소드를 활용 해 OCP를 지키는 코드를 짜신 것이 인상 깊었습니다! 다만LogicFactory나 getLogic 같은 클래스명, 메소드명은 이름을 통해 어떤 내용인지 유추하기 어려운 것 같습니다. ItemUpdateLogic 같이 명확한 메소드를 사용하는 것은 어떨까요?
|
|
||
| private void decreaseQualityTwice(Item item) { | ||
| if (item.quality > 0) { | ||
| item.quality = Math.max(0, item.quality - 2); |
There was a problem hiding this comment.
if문을 한번 더 사용하는 것이 아닌 Math.max 메소드를 통해 quality를 결정하는 방식 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.