-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[신윤섭] 5차 과제 제출 #28
Open
supsup-hae
wants to merge
26
commits into
IT-Cotato:develop
Choose a base branch
from
supsup-hae:yunseop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[신윤섭] 5차 과제 제출 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- key 값이 공유 되지 않도록 application.properties 제외
- SaveSinglePostRequest.java - SavePostsByExcelRequest.java
- id를 기반으로 게시글 생성 - request dto을 record로 변경 시 생긴 코드 수정 반영
- AUTO -> IDENTITY
- JdbcTemplate를 이용한 Batch Insert
- id를 기반으로 게시글 조회 및 영속성 컨텍스트 이용한 조회수 증가
- 오타 수정 및 직관적인 네이밍 반영
- likes를 기반으로한 Pageable 정렬 기능 추가 위함
- 페이지네이션과 추가 기능(현재, 전체 페이지 수) 구현 - likes 값에 따른 DESC 정렬
- 메서드명을 더 정확하게 수정 - URI 경로를 RESTful 원칙에 맞게 수정 - /search → /{id} - /single → / - /delete → /{id}
- `view` 적용
- `PostDto` -> `PostResponse`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
문제 해결 과정
1. 기존 코드 시간 측정
10
,100
,500
,1000
회 요청을 기준으로 측정을 진행하였다.2. 해결 과정
2-1. Index
500(8280 -> 3079)
,1000(10401 -> 3194)
로 대략 60 - 70%의 성능 개선이 진행되었다!.2-2. cache
10 (331 -> 134)
,100(1872 -> 196)
,500( 8280 -> 409)
,1000( 10401 -> 164)
Race Condition
이 발생한 게 아닐까 한다.