Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Update README.md #110

Merged
merged 3 commits into from
Jan 25, 2024
Merged

📚 Update README.md #110

merged 3 commits into from
Jan 25, 2024

Conversation

elisabettai
Copy link
Contributor

Added link to webinar

Added link to webinar
@elisabettai elisabettai enabled auto-merge (squash) August 28, 2023 09:43
@elisabettai
Copy link
Contributor Author

elisabettai commented Aug 28, 2023

Hi @pcrespov, I see that the CI is failing with some issues regarding 'jinja2_time'. fyi: I saw that locally when using the cookiecutter some weeks ago as well.
Let me know if you know how to solve, otherwise I can also take a look.

@pcrespov
Copy link
Member

Hi @pcrespov, I see that the CI is failing with some issues regarding 'jinja2_time'. fyi: I saw that locally when using the cookiecutter some weeks ago as well. Let me know if you know how to solve, otherwise I can also take a look.

@elisabettai the CI in https://github.com/ITISFoundation/cookiecutter-osparc-service/actions/runs/5997638565/job/16264399226#step:6:241 shows that jinja2 is installed. My guess is that the version is not pinned and a new upgrade happen in which they removed the dependency to jinja_time. It might be that you need to add an extra as jinja2[time] ... not sure.
If this is the case, solutions might go by pin jinja2 to an older version or add the missing library in the requirements
Can you please investigate further and take this issue?

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not forget to fill the attributes of the PR (.e.g assignee, milestone, etc) so we can track them properly . thx :-)

README.md Outdated Show resolved Hide resolved
@elisabettai elisabettai added this to the This is Sparta! milestone Jan 25, 2024
@elisabettai elisabettai added a:doc documentation, reporting, admin tasks dependencies Pull requests that update a dependency file labels Jan 25, 2024
@elisabettai elisabettai merged commit d95ed13 into master Jan 25, 2024
2 checks passed
@elisabettai elisabettai deleted the elisabettai-patch-1 branch January 25, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:doc documentation, reporting, admin tasks dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants