-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 unarchiving_utils are now based on 7zip cli #6959
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6959 +/- ##
==========================================
- Coverage 86.89% 86.80% -0.10%
==========================================
Files 1633 1298 -335
Lines 64589 55517 -9072
Branches 2041 1159 -882
==========================================
- Hits 56125 48191 -7934
+ Misses 8129 7114 -1015
+ Partials 335 212 -123
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the idea behing this change?
Also I was wondering:
- the dask-sidecar checks the input file mime type. if it is set to zip, then it does not uncompress
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read my additional comments. I don't undersatnd how you wanna present this error to the user.
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
@giancarloromeo @matusdrobuliak66 @sanderegg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, but please let's look at some of the comments. we can have a quick chat.
packages/service-library/src/servicelib/archiving_utils/_errors.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/archiving_utils/_interface_7zip.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/archiving_utils/_interface_7zip.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/archiving_utils/_interface_7zip.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/archiving_utils/_interface_7zip.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/nodeports.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Quality Gate passedIssues Measures |
What do these changes do?
When a new style dynamic service has to fetch an input port containing a zip archive, it will try to unzip it.
If it's not able to open it (see issue here), the service would fail to start.
Important changes:
drop-in
implementation using7zip
cli for archiving and unarchiving7zip
alo addresses Deflate64 zip-files not supported by dynamic-sidecar powered services #2843Related issue/s
How to test
Dev-ops checklist