Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --download option to appmanager upload #778

Merged
merged 1 commit into from
Feb 5, 2015
Merged

Add --download option to appmanager upload #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/commands/appmanager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import MobileHelper = require("../common/mobile/mobile-helper");
import constants = require("../common/mobile/constants");
import util = require("util");
import options = require("../options");

class AppManagerUploadCommand implements ICommand {
constructor(
Expand Down Expand Up @@ -31,7 +32,8 @@ class AppManagerUploadCommand implements ICommand {
configuration: "Release",
provisionTypes: [constants.ProvisionType.Development, constants.ProvisionType.Enterprise, constants.ProvisionType.AdHoc],
showWp8SigningMessage: false,
buildForTAM: true
buildForTAM: true,
downloadFiles: options.download
}).wait();

if (!buildResult[0] || !buildResult[0].solutionPath) {
Expand Down
2 changes: 1 addition & 1 deletion lib/services/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ export class BuildService implements Project.IBuildService {
var buildResult = this.requestCloudBuild(settings).wait();
var packageDefs = buildResult.packageDefs;

if(buildResult.provisionType === constants.ProvisionType.Development && !settings.downloadFiles) {
if(buildResult.provisionType === constants.ProvisionType.Development && !settings.downloadFiles && !settings.buildForTAM) {
this.$logger.info("Package built with 'Development' provision type. Downloading package, instead of generating QR code.");
this.$logger.info("Deploy manually to your device using iTunes.");
settings.showQrCodes = false;
Expand Down
3 changes: 2 additions & 1 deletion resources/help.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ This command is not applicable to Mobile Website projects.

--[appmanager|upload]--
Usage:
$ appbuilder appmanager upload <Platform> [--certificate <Certificate ID>] [--provision <Provision ID>]
$ appbuilder appmanager upload <Platform> [--certificate <Certificate ID>] [--provision <Provision ID>] [--download]

Platform-specific usage:
$ appbuilder appmanager upload android --certificate <Certificate ID>
Expand All @@ -997,6 +997,7 @@ Options:
--provision - Sets the provisioning profile that you want to use for code signing your iOS app. You can set
a provisioning profile by index or name.
To list available provisioning profiles, run $ appbuilder provision
--download - If set, downloads the application package to the root of the project
--[/]--

--[certificate-request]--
Expand Down