-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pr #285 ini numbers #286 host icinga2 objects #287
base: main
Are you sure you want to change the base?
Fix pr #285 ini numbers #286 host icinga2 objects #287
Conversation
Hi matt, thanks for your PR. Can you change the PR to the fix for the numeric value problem? Do you know if this is backwards compatible? |
I added tests for this case: https://github.com/Icinga/ansible-collection-icinga/actions/runs/9221232221/job/25369843073 But with jinja 3.1.4 which is in this testcase the latest version - it works without issue.
|
ping @sol1-matt - is this still a problem or does it work with the newer versions of jinja? |
@mkayontour the base OS was Debian 12, so the versions of ansible and jninja in the tickets were from the latest packages available with the OS. We didn't try pulling down the latest versions of jninja and installing outside OS package management. The fork where these changes are coming from (https://github.com/sol1-ansible/ansible-collection-icinga/tree/defaults_roles) is what we have been using to install all our recent Icinga clusters (5 since I posted this) but I haven't tested if taking it out causes it to break again. I assume it would as the OS's for ansible have primarily been Debian 12 though we do run AWX, I think that goes on a red hat based OS but I've not had to set that up myself. I have another install this morning from a Debian 11 ansible system, I'll test the |
Any updates? |
@mkayontour the fix |
Fix #286 Adding icinga2_objects to inventory/host_vars does nothing
Fix #285 Jninja error generating icingaweb2 where some values are numeric