Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the task restarting apache2 and icinga2 #79

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

maccadia
Copy link
Contributor

The task Restart HTTPD and Icinga2 to Apply the Configuration results in changes at each playbook execution. This is unnecessary. I have tested without this task and with some notify statements ; it works. Related issue: #50.

Note: this PR removes also a duplicate of task Configure Icinga2 Ido Mysql Feature

Identical task already above (lines 53-60)
Apache2 and Icinga2 are restarted at every playbook run. Use notify
instead.
@aflatto
Copy link
Contributor

aflatto commented Apr 5, 2018

@maccadia
Thank you for your contribution, Please test the changes also on RedHat based distribution.

We can not accept a changed for only a part of the functionality provided in the Role.

@kaistian
Copy link

Please test the changes also on RedHat based distribution.

This PR only changes icinga2_web2_ui_Debian_install.yml, a file only run on Debian based distribution. Why would this change need to be tested against RedHat when the file never run on these distribution?

@maccadia
Copy link
Contributor Author

I think that what @aflatto had in mind was that the task(s) Restart {{ web_server_daemon }} and Icinga2 to Apply the Configuration in icinga2_web2_ui_RedHat_install.yml should be removed too in order to keep the same logic in both playbooks.

@kaistian
Copy link

I see.
The problem I see with that approach is fewer people that can or are willing to contribute since they need to test on a unfamiliar distribution.

@aflatto aflatto merged commit b3b22d9 into Icinga:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants