Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test com.Atomic #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test com.Atomic #35

wants to merge 3 commits into from

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov added the enhancement New feature or request label Jul 8, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 8, 2024
@oxzi oxzi added the tests Adding tests to existing code label Jul 19, 2024
@Al2Klimov Al2Klimov removed the enhancement New feature or request label Jul 19, 2024
@Al2Klimov Al2Klimov requested a review from oxzi September 6, 2024 08:07
oxzi
oxzi approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

But honestly, I am unsure about the value of those tests as the tested code is a very thin wrapper around Go's atomic.Value, just adding generic type information.

@lippserd
Copy link
Member

I would rather remove that type completely. See Icinga/icingadb#812.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi approved these changes

Assignees
No one assigned
Labels
cla/signed CLA is signed by all contributors of a PR tests Adding tests to existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al2Klimov @lippserd @oxzi