Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test com.Counter #47

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Test com.Counter #47

merged 3 commits into from
Sep 2, 2024

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov added the tests Adding tests to existing code label Jul 19, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 19, 2024
oxzi
oxzi requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the two test functions could be merged in one, as the only difference is that the second one has an additional Reset() call.

com/counter_test.go Outdated Show resolved Hide resolved
@Al2Klimov
Copy link
Member Author

But the first one tests serial adds w/o reset.

@yhabteab yhabteab added this to the 0.4.0 milestone Sep 2, 2024
@yhabteab yhabteab merged commit 15703e6 into main Sep 2, 2024
2 checks passed
@yhabteab yhabteab deleted the test-Counter branch September 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi approved these changes

Assignees
No one assigned
Labels
cla/signed CLA is signed by all contributors of a PR tests Adding tests to existing code
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Al2Klimov @oxzi @yhabteab