Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually retry every database error, including "pq: ..." #59

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Actually retry every database error, including "pq: ..." #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions retry/retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/pkg/errors"
"io"
"net"
"strings"
"syscall"
"time"
)
Expand Down Expand Up @@ -197,5 +198,12 @@ func Retryable(err error) bool {
return true
}

// For errors without a five-digit code, github.com/lib/pq uses fmt.Errorf().
// This returns an unexported error type prefixed with "pq: "
// Until this gets changed upstream <https://github.com/lib/pq/issues/1169>, we can only check the error message.
if strings.HasPrefix(err.Error(), "pq: ") {
return true
}

return false
}
Loading