Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to dynamically define type constraint name #7

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Allow to dynamically define type constraint name #7

merged 1 commit into from
Feb 5, 2024

Conversation

yhabteab
Copy link
Member

This allows us to dynamically determine the constraint names used for the UPSERT and INSERT IGNORE statements for the PostgreSQL driver.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jan 19, 2024
@yhabteab yhabteab requested a review from lippserd January 19, 2024 14:17
@yhabteab yhabteab mentioned this pull request Jan 22, 2024
Closed
@yhabteab yhabteab requested review from lippserd and removed request for lippserd January 22, 2024 12:55
lippserd
lippserd requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is PostgreSQL specific I would reflect that in the interface/function name. I know it's rather long but what about something like PostgresOnConflictConstraint()?

@yhabteab yhabteab requested a review from lippserd January 22, 2024 15:33
lippserd
lippserd requested changes Jan 29, 2024
View reviewed changes
database/contracts.go Outdated Show resolved Hide resolved
lippserd
lippserd requested changes Jan 29, 2024
View reviewed changes
database/contracts.go Outdated Show resolved Hide resolved
@yhabteab yhabteab requested a review from lippserd February 5, 2024 07:42
lippserd
lippserd approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to merge.

@yhabteab yhabteab merged commit f0e227c into main Feb 5, 2024
2 checks passed
@yhabteab yhabteab deleted the constrainter branch February 5, 2024 10:28
@lippserd
Copy link
Member

Main branch was force pushed because the latest version of the Icinga Go library and the library code in the Icinga DB have diverged. This change is now reflected by commit 54491de.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd lippserd approved these changes

Assignees
No one assigned
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabteab @lippserd