Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard navigation in item tables #1038

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fix keyboard navigation in item tables #1038

merged 3 commits into from
Jul 31, 2024

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 added bug Something isn't working area/ui Affects the user interface labels Jul 29, 2024
@sukhwinder33445 sukhwinder33445 self-assigned this Jul 29, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 29, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the fix/action-list branch 4 times, most recently from ea9ff6f to ab28ac5 Compare July 30, 2024 11:09
public/js/action-list.js Outdated Show resolved Hide resolved
public/js/action-list.js Outdated Show resolved Hide resolved
public/js/action-list.js Outdated Show resolved Hide resolved
public/js/action-list.js Outdated Show resolved Hide resolved
The list items of icingadb/(hostgroups/servicegroups) have the css property `display:contents`, which leads to the scrollIntoView() function having no effect.
@nilmerg nilmerg added area/javascript Affects client-side scripting and removed area/ui Affects the user interface labels Jul 31, 2024
@nilmerg nilmerg added this to the 1.1.3 milestone Jul 31, 2024
@nilmerg nilmerg merged commit 0782c48 into main Jul 31, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/action-list branch July 31, 2024 09:38
@nilmerg nilmerg changed the title action-list: Take items with css propery display:contents into account Fix keyboard navigation in item tables Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Affects client-side scripting bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants