History: Sort also by type by default #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
enhancement
julianbrost
reviewed
Jun 5, 2023
There was a problem hiding this comment.
So the overall plan here is to sort it as good as easily possible with event_type (i.e. without defining a separate sort order within the web module) and if other tweaks to the sort order are needed, these have to be done as a schema change?
Anyway, this change shouldn't cause problems as a sort order returned for order by a, b would also be valid for order by a.
I gave this a quick test (manually patched the file in my running container): no surprises regarding the sort order itself, but now the sort dropdown shows "Custom".
raviks789
reviewed
Jun 6, 2023
nilmerg
force-pushed
the
sort-history-also-by-type
branch
from
4ff3197
to
3c9cc2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #587