Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize that a check or downtime is running #777

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Visualize that a check or downtime is running #777

merged 5 commits into from
Jun 22, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jun 9, 2023 •
edited
Loading

@nilmerg nilmerg added enhancement New feature or improvement area/representation Affects the representation of information labels Jun 9, 2023
@nilmerg nilmerg added this to the 1.1.0 milestone Jun 9, 2023
@nilmerg nilmerg self-assigned this Jun 9, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jun 9, 2023
@nilmerg nilmerg changed the title Visualze that a check or downtime is running Visualize that a check or downtime is running Jun 9, 2023
@nilmerg nilmerg force-pushed the feature/visualize-running-checks-493 branch 2 times, most recently from 6236d15 to a8c7dcb Compare June 13, 2023 14:29
@nilmerg nilmerg requested a review from flourish86 June 13, 2023 14:30
@flourish86
Copy link
Contributor

Here’s a mockup of how we could solve the problem, with relatively short extecution times (which should be the most common case)

Frame 43

@nilmerg nilmerg force-pushed the feature/visualize-running-checks-493 branch 2 times, most recently from 1561667 to 72dd7a5 Compare June 21, 2023 13:36
@nilmerg nilmerg marked this pull request as ready for review June 21, 2023 13:37
flourish86
flourish86 previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@flourish86 flourish86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes. Everything else seems fine to me.

@flourish86 flourish86 force-pushed the feature/visualize-running-checks-493 branch from 37e7fef to 31285ad Compare June 21, 2023 14:29
@nilmerg nilmerg force-pushed the feature/visualize-running-checks-493 branch from 31285ad to 0401e75 Compare June 22, 2023 12:56
@nilmerg nilmerg merged commit 67fc7f5 into master Jun 22, 2023
@nilmerg nilmerg deleted the feature/visualize-running-checks-493 branch June 22, 2023 13:25
@dwt
Copy link

dwt commented Jul 7, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flourish86 flourish86 flourish86 left review comments

Assignees

@nilmerg nilmerg

Labels
area/representation Affects the representation of information cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Visualize that a check is currently running
3 participants
@nilmerg @flourish86 @dwt