Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that unreachable hosts and services are not shown as such #803

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Fix that unreachable hosts and services are not shown as such #803

merged 6 commits into from
Jul 21, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jul 10, 2023 •
edited
Loading

fixes #802

@nilmerg nilmerg added bug Something isn't working area/representation Affects the representation of information labels Jul 10, 2023
@nilmerg nilmerg added this to the 1.1.0 milestone Jul 10, 2023
@nilmerg nilmerg self-assigned this Jul 10, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 10, 2023
@nilmerg nilmerg force-pushed the fix/unreachable-hosts-and-services-not-shown-802 branch from 74b5a5d to 7ecd414 Compare July 10, 2023 15:21
@nilmerg
Copy link
Member Author

nilmerg commented Jul 10, 2023

Implemented based on this configuration:

object Host "switch" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    vars.dummy_state = 2
    vars.issue_no = 802
    vars.mixed_case = "foo"
}

object Host "pc1" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    vars.dummy_state = 2
    vars.issue_no = 802
}

object Service "pc1-disk" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    host_name = "pc1"

    vars.issue_no = 802
    vars.dummy_state = 3
}

object Dependency "pc1-switch" {
  parent_host_name = "switch"

  child_host_name = "pc1"

  states = [ Up ]

  disable_checks = true
}

object Host "pc2" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m
    enable_active_checks = false

    vars.dummy_state = 2
    vars.issue_no = 802
}

object Dependency "pc2-switch" {
  parent_host_name = "switch"

  child_host_name = "pc2"

  states = [ Up ]

  disable_checks = true
}

object Host "pc3" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    vars.dummy_state = 0
    vars.issue_no = 802
}

object Service "pc3-os" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    host_name = "pc3"

    vars.issue_no = 802
    vars.dummy_state = 3
}

object Service "pc3-service" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    host_name = "pc3"

    vars.issue_no = 802
    vars.dummy_state = 3
}

object Dependency "pc3-service-os" {
  parent_host_name = "pc3"
  parent_service_name = "pc3-os"

  child_host_name = "pc3"
  child_service_name = "pc3-service"

  states = [ OK, Warning ]

  disable_checks = true
}

object Host "status-2" {
    check_command = "dummy"
    check_interval = 5m
    retry_interval = 1m

    vars.dummy_state = 3
    vars.issue_no = 802
}

@nilmerg nilmerg requested a review from flourish86 July 10, 2023 15:23
@nilmerg nilmerg force-pushed the fix/unreachable-hosts-and-services-not-shown-802 branch 3 times, most recently from 943b521 to 842165c Compare July 20, 2023 11:11
@nilmerg
Drop dead code trying to visualize unreachable hosts
b2bbe2c
@nilmerg
CheckStatistics: Drop check source state ball
aa64e52 
It's based on the objects reachable state, but this
doesn't seem to relate to the check source at all.
@nilmerg
StateBadges: Require a real filter in method createLink
34ecf5d
@nilmerg
Properly visualize unreachable hosts
87db460 
* Lists show it in their visual and title area
* The tatical view includes a slice for them
* State badges (list footers, hostgroups) also show a badge
@nilmerg
Properly visualize unreachable services
52cd8d4 
* Lists show it in their visual and title area
* The tatical view includes a slice for them
* State badges (list footers, host-/servicegroups) also show a badge
@nilmerg
progress-bar.less: Hide ::before if progress is not animated
966bb50
@nilmerg nilmerg force-pushed the fix/unreachable-hosts-and-services-not-shown-802 branch from e815f3b to 966bb50 Compare July 21, 2023 08:24
@nilmerg nilmerg merged commit cd5f74b into master Jul 21, 2023
@nilmerg nilmerg deleted the fix/unreachable-hosts-and-services-not-shown-802 branch July 21, 2023 08:30
sukhwinder33445 added a commit to Icinga/icingaweb2-module-cube that referenced this pull request Mar 25, 2024
@sukhwinder33445
Fix broken view with unreachable hosts
24af130 
Icingadb-web no longer has the unreachable state and the Hoststatesummary columns `hosts_unreachable_handled` and `hosts_unreachable_unhandled` are removed in Icinga/icingadb-web#803.
The unreachable column is merged as the following:

* hosts_down_handled = (down && (handled || ! reachable)
* hosts_down_unhandled = (down && ! handled && reachable)
@sukhwinder33445 sukhwinder33445 mentioned this pull request Mar 25, 2024
Merged
sukhwinder33445 added a commit to Icinga/icingaweb2-module-cube that referenced this pull request Mar 25, 2024
@sukhwinder33445
SeveritySort: Remove undefined column hosts(_unhandled)_unreachable
3a5a56f 
Icingadb-web no longer has the unreachable state and the `Hoststatesummary` columns `hosts_unreachable_handled` and `hosts_unreachable_unhandled` are removed. (see: Icinga/icingadb-web#803).
The unreachable column is merged as the following:

* hosts_down_handled = (down && (handled || ! reachable)
* hosts_down_unhandled = (down && ! handled && reachable)
sukhwinder33445 added a commit to Icinga/icingaweb2-module-cube that referenced this pull request Mar 25, 2024
@sukhwinder33445
SeveritySort: Remove undefined column hosts(_unhandled)_unreachable
cb0b10c 
Icingadb-web no longer has the unreachable state and the `Hoststatesummary` columns `hosts_unreachable_handled` and `hosts_unreachable_unhandled` are removed. (see: Icinga/icingadb-web#803).
The unreachable column is merged as the following:

* hosts_down_handled = (down && (handled || ! reachable)
* hosts_down_unhandled = (down && ! handled && reachable)
sukhwinder33445 added a commit to Icinga/icingaweb2-module-cube that referenced this pull request Apr 12, 2024
@sukhwinder33445
SeveritySort: Remove undefined column hosts(_unhandled)_unreachable
287bd02 
Icingadb-web no longer has the unreachable state and the `Hoststatesummary` columns `hosts_unreachable_handled` and `hosts_unreachable_unhandled` are removed. (see: Icinga/icingadb-web#803).
The unreachable column is merged as the following:

* hosts_down_handled = (down && (handled || ! reachable)
* hosts_down_unhandled = (down && ! handled && reachable)
sukhwinder33445 added a commit to Icinga/icingaweb2-module-cube that referenced this pull request Apr 12, 2024
@sukhwinder33445
SeveritySort: Remove undefined column hosts(_unhandled)_unreachable
fbfbe00 
Icingadb-web no longer has the unreachable state and the `Hoststatesummary` columns `hosts_unreachable_handled` and `hosts_unreachable_unhandled` are removed. (see: Icinga/icingadb-web#803).
The unreachable column is merged as the following:

* hosts_down_handled = (down && (handled || ! reachable)
* hosts_down_unhandled = (down && ! handled && reachable)
nilmerg pushed a commit to Icinga/icingaweb2-module-cube that referenced this pull request Apr 12, 2024
@sukhwinder33445 @nilmerg
SeveritySort: Remove undefined column hosts(_unhandled)_unreachable
befa81c 
Icingadb-web no longer has the unreachable state and the `Hoststatesummary` columns `hosts_unreachable_handled` and `hosts_unreachable_unhandled` are removed. (see: Icinga/icingadb-web#803).
The unreachable column is merged as the following:

* hosts_down_handled = (down && (handled || ! reachable)
* hosts_down_unhandled = (down && ! handled && reachable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flourish86 flourish86 flourish86 approved these changes

Assignees

@nilmerg nilmerg

Labels
area/representation Affects the representation of information bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Unreachable hosts not shown as such
2 participants
@nilmerg @flourish86