retry.Retryable(): re-try MySQL error 1047 for a "not yet prepared node" #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes that would be great, thanks! |
oxzi
reviewed
Feb 15, 2024
pkg/retry/retry.go
Outdated
| @@ -150,6 +150,8 @@ func Retryable(err error) bool { | |||
| // 1213: Deadlock found when trying to get lock | |||
| // 2006: MySQL server has gone away | |||
| return true | |||
| case 1047: // Unknown command | |||
| return strings.Contains(e.Message, "not yet prepared node") | |||
There was a problem hiding this comment.
Why not match against the fully known message as stated in the PR's initial text?
Furthermore, maybe add a comment to explain this line as it is not self-explaining.
During start a Galera cluster complains with "WSREP has not yet prepared node for application use". But the error code, 1047, stands for "Unknown command". So re-try only a "not yet prepared node", but not an "Unknown command".
Al2Klimov
force-pushed
the
Retryable-1047
branch
from
75170ca to
85954dd
Compare
|
@NavidSassan You can download the Job artifacts here: https://git.icinga.com/packages/icingadb/-/jobs/481689 That includes #665 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During start a Galera cluster complains with "WSREP has not yet prepared node for application use". But the error code, 1047, stands for "Unknown command". So re-try only a "not yet prepared node", but not an "Unknown command".
ref/IP/48748
@NavidSassan Do you want packages with status quo plus this one?